From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v5, 2/5] mtd: nand: force NAND_CMD_READID onto 8-bit bus
Date: Fri, 6 Jun 2014 17:54:23 -0400 [thread overview]
Message-ID: <20140606215423.GX7841@bill-the-cat> (raw)
In-Reply-To: <1399317380-16755-3-git-send-email-pekon@ti.com>
On Tue, May 06, 2014 at 12:46:17AM +0530, pekon gupta wrote:
> From: Brian Norris <computersforpeace@gmail.com>
>
> As per following Sections in ONFI Spec, NAND_CMD_READID should use only
> lower 8-bit for transfering command, address and data even on x16 NAND device.
>
> *Section: Target Initialization"
> "The Read ID and Read Parameter Page commands only use the lower 8-bits of the
> data bus. The host shall not issue commands that use a word data width on x16
> devices until the host determines the device supports a 16-bit data bus width
> in the parameter page."
>
> *Section: Bus Width Requirements*
> "When the host supports a 16-bit bus width, only data is transferred at the
> 16-bit width. All address and command line transfers shall use only the lower
> 8-bits of the data bus. During command transfers, the host may place any value
> on the upper 8-bits of the data bus. During address transfers, the host shall
> set the upper 8-bits of the data bus to 00h."
>
> Thus porting following commit from linux-kernel to ensure that column address
> is not altered to align to x16 bus when issuing NAND_CMD_READID command.
>
> commit 3dad2344e92c6e1aeae42df1c4824f307c51bcc7
> mtd: nand: force NAND_CMD_READID onto 8-bit bus
> Author: Brian Norris <computersforpeace@gmail.com> (preserving authorship)
>
> The NAND command helpers tend to automatically shift the column address
> for x16 bus devices, since most commands expect a word address, not a
> byte address. The Read ID command, however, expects an 8-bit address
> (i.e., 0x00, 0x20, or 0x40 should not be translated to 0x00, 0x10, or
> 0x20).
>
> This fixes the column address for a few drivers which imitate the
> nand_base defaults.
>
> Signed-off-by: Pekon Gupta <pekon@ti.com>
Applied to u-boot-ti/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140606/f6752c41/attachment.pgp>
next prev parent reply other threads:[~2014-06-06 21:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 19:16 [U-Boot] [PATCH v5 0/5] enable support for x16 NAND devices Pekon Gupta
2014-05-05 19:16 ` [U-Boot] [PATCH v5 1/5] mtd: nand: don't use read_buf for 8-bit ONFI transfers Pekon Gupta
2014-06-06 21:54 ` [U-Boot] [U-Boot, v5, " Tom Rini
2014-05-05 19:16 ` [U-Boot] [PATCH v5 2/5] mtd: nand: force NAND_CMD_READID onto 8-bit bus Pekon Gupta
2014-06-06 21:54 ` Tom Rini [this message]
2014-05-05 19:16 ` [U-Boot] [PATCH v5 3/5] mtd: nand: fix GET/SET_FEATURES address on 16-bit devices Pekon Gupta
2014-06-06 21:54 ` [U-Boot] [U-Boot, v5, " Tom Rini
2014-05-05 19:16 ` [U-Boot] [PATCH v5 4/5] mtd: nand: omap: add CONFIG_SYS_NAND_BUSWIDTH_16BIT to indicate NAND device bus-width Pekon Gupta
2014-06-06 21:54 ` [U-Boot] [U-Boot, v5, " Tom Rini
2014-05-05 19:16 ` [U-Boot] [PATCH v5 5/5] omap3: remove remnant macros GPMC_NAND_ECC_LP_x8_LAYOUT and GPMC_NAND_ECC_LP_x16_LAYOUT Pekon Gupta
2014-06-06 21:54 ` [U-Boot] [U-Boot, v5, " Tom Rini
2014-05-27 11:48 ` [U-Boot] [PATCH v5 0/5] enable support for x16 NAND devices Gupta, Pekon
2014-05-27 17:21 ` [U-Boot] NAND custodian (was Re: [PATCH v5 0/5] enable support for x16 NAND devices) Scott Wood
2014-05-28 21:00 ` Tom Rini
2014-05-29 5:28 ` Heiko Schocher
2014-05-30 4:54 ` Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606215423.GX7841@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox