From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 14/15] dm: Tidy up four minor code nits
Date: Sun, 8 Jun 2014 07:01:00 +0200 [thread overview]
Message-ID: <201406080701.00287.marex@denx.de> (raw)
In-Reply-To: <1402082012-4152-15-git-send-email-sjg@chromium.org>
On Friday, June 06, 2014 at 09:13:31 PM, Simon Glass wrote:
> There is a spelling mistake and two functions are missing comments
> altogether. Also the flags declaration is correct, but doesn't follow
> style. Finally, the uclass_get_device() function has some errors in
> its documentation.
[...]
> --- a/include/dm/uclass.h
> +++ b/include/dm/uclass.h
> @@ -96,12 +96,14 @@ int uclass_get(enum uclass_id key, struct uclass
> **ucp); /**
> * uclass_get_device() - Get a uclass device based on an ID and index
> *
> + * The device is probed to activate it ready for use.
> + *
> * id: ID to look up
> * @index: Device number within that uclass (0=first)
> - * @ucp: Returns pointer to uclass (there is only one per for each ID)
> + * devp: Returns pointer to device (there is only one per for each ID)
You're missing the leading @ in "devp" here for consistency's sake.
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-06-08 5:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 19:13 [U-Boot] [PATCH v4 0/15] Collected driver model bug-fixes and docs Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 01/15] Add an I/O tracing feature Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 02/15] arm: Support iotrace feature Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 03/15] sandbox: " Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 04/15] Makefile: Support include files for .dts files Simon Glass
2014-06-06 20:29 ` Jon Loeliger
2014-06-06 20:44 ` Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 05/15] dm: Rename struct device_id to udevice_id Simon Glass
2014-06-06 20:26 ` Jon Loeliger
2014-06-06 20:30 ` Jon Loeliger
2014-06-06 20:36 ` Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 06/15] dm: Update README to encourage conversion to driver model Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 07/15] dm: Use case-insensitive comparison for GPIO banks Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 08/15] dm: Add missing header files in lists and root Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 09/15] dm: Cast away the const-ness of the global_data pointer Simon Glass
2014-06-08 5:00 ` Marek Vasut
2014-06-12 3:26 ` Simon Glass
2014-06-12 3:29 ` Simon Glass
2014-06-17 23:42 ` Marek Vasut
2014-06-18 5:36 ` Simon Glass
2014-06-20 4:07 ` Simon Glass
2014-06-20 4:12 ` Marek Vasut
2014-06-20 20:34 ` Simon Glass
2014-06-20 21:45 ` Marek Vasut
2014-06-06 19:13 ` [U-Boot] [PATCH v4 10/15] dm: Allow driver model tests only for sandbox Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 11/15] dm: Fix printf() strings in the 'dm' command Simon Glass
2014-06-08 22:46 ` Andre Renaud
2014-06-12 3:34 ` Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 12/15] tegra: dts: Bring in GPIO bindings from linux Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 13/15] tegra: Enable driver model Simon Glass
2014-06-06 19:13 ` [U-Boot] [PATCH v4 14/15] dm: Tidy up four minor code nits Simon Glass
2014-06-08 5:01 ` Marek Vasut [this message]
2014-06-06 19:13 ` [U-Boot] [PATCH v4 15/15] dm: Expand and improve the device lifecycle docs Simon Glass
2014-06-06 19:52 ` Pavel Herrmann
2014-06-06 20:42 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201406080701.00287.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox