From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ
Date: Mon, 09 Jun 2014 20:19:38 +0900 [thread overview]
Message-ID: <20140609201938.95D2.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <E1Wtw5b-0005tD-PF@janus>
Hi Albert,
> Sorry, I though your patch was about CONFIG_USE_IRQ and its related
> feature, as the subject and commit message both heavily refer to it
> and mention CONFIG_SYS_DV_NOR_BOOT_CFG almost incidentally.
>
> Since the issue is that CONFIG_SYS_DV_NOR_BOOT_CFG definition is broken
> for three mainline targets, then then please repost a V2 of your
> patch, with an amended commit message (and subject) which make it clear
> that the problem is with CONFIG_SYS_DV_NOR_BOOT_CFG breaking these
> boards, not with CONFIG_USE_IRQ which is unused anyway. I will then make
> sure to apply your V2 patch ASAP as it is a bug fix.
>
The CONFIG_SYS_DV_NOR_BOOT_CFG problem cannot be detected
by build test only.
Because you only check if all ARM boards succeed in compile or not,
I thought CONFIG_USE_IRQ problem would be clearer to understand.
But the fact was opposite from my expectation. :-(
Anyway, I've posted v2 with amended comments.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-06-09 11:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 10:43 [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ Masahiro Yamada
2014-06-09 7:14 ` Albert ARIBAUD
2014-06-09 7:36 ` Masahiro Yamada
2014-06-09 8:35 ` Albert ARIBAUD
2014-06-09 9:29 ` Masahiro Yamada
2014-06-09 9:42 ` Albert ARIBAUD
2014-06-09 11:19 ` Masahiro Yamada [this message]
2014-06-11 7:14 ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned (was: [PATCH] arm: fix a build error with CONFIG_USE_IRQ) Albert ARIBAUD
2014-06-11 7:47 ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned Heiko Schocher
2014-06-11 13:15 ` Christian Riesch
2014-06-12 8:05 ` Christian Riesch
2014-06-13 7:46 ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned (was: [PATCH] arm: fix a build error with CONFIG_USE_IRQ) Masahiro Yamada
2014-06-18 12:55 ` Christian Riesch
2014-06-18 13:08 ` Christian Riesch
2014-07-02 13:45 ` Christian Riesch
2014-07-04 20:35 ` Albert ARIBAUD
2014-07-07 7:15 ` Christian Riesch
2014-07-07 8:55 ` Christian Riesch
2014-06-09 11:18 ` [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609201938.95D2.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox