From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 10 Jun 2014 08:50:31 +0200 Subject: [U-Boot] [PATCH 1/3] usb:g_dnl:f_thor: remove memset before memcpy In-Reply-To: <1402320540-17058-2-git-send-email-jeroen@myspectrum.nl> References: <1402320540-17058-1-git-send-email-jeroen@myspectrum.nl> <1402320540-17058-2-git-send-email-jeroen@myspectrum.nl> Message-ID: <20140610085031.256beeff@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jeroen, > since ALLOC_CACHE_ALIGN_BUFFER defines a pointer and not a > buffer, the memset with sizeof(rqt) likely does something else > then intended. Since there is a memcpy directly after it with > the full size, drop the memset completely. Acked-by: Lukasz Majewski > > Cc: Lukasz Majewski > Cc: Marek Vasut > Signed-off-by: Jeroen Hofstee > --- > drivers/usb/gadget/f_thor.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c > index 28f215e..4e06273 100644 > --- a/drivers/usb/gadget/f_thor.c > +++ b/drivers/usb/gadget/f_thor.c > @@ -306,7 +306,6 @@ static int process_data(void) > ALLOC_CACHE_ALIGN_BUFFER(struct rqt_box, rqt, sizeof(struct > rqt_box)); int ret = -EINVAL; > > - memset(rqt, 0, sizeof(rqt)); > memcpy(rqt, thor_rx_data_buf, sizeof(struct rqt_box)); > > debug("+RQT: %d, %d\n", rqt->rqt, rqt->rqt_data); -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group