From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 07/14] fdt: Add DEV_TREE_BIN option to specify a device tree binary file
Date: Tue, 10 Jun 2014 14:59:23 +0900 [thread overview]
Message-ID: <20140610145923.95FF.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1401768297-7198-8-git-send-email-sjg@chromium.org>
Hi Simon,
On Mon, 2 Jun 2014 22:04:50 -0600
Simon Glass <sjg@chromium.org> wrote:
> In some cases, an externally-built device tree binary is required to be
> attached to U-Boot. An example is when using image signing, since in that
> case the .dtb file must include the public keys.
I do not want to expand this argument, but
I am not sure if DTB stands for "device tree binary".
linux/Documentation often refer it as "device tree blob",
while linux/Documentation/devicetree/booting-without-of.txt
says "device tree block".
> Add a DEV_TREE_BIN option to the Makefile, and update the documentation.
Is it possible to rename it without mentioning _BIN or _BLOB ?
For example, DTB_PATH=... or EXT_DTB=...
or some other variable name you like.
> diff --git a/Makefile b/Makefile
> index ece622f..92819bf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -867,7 +867,7 @@ MKIMAGEFLAGS_u-boot.kwb = -n $(srctree)/$(CONFIG_SYS_KWD_CONFIG:"%"=%) \
> MKIMAGEFLAGS_u-boot.pbl = -n $(srctree)/$(CONFIG_SYS_FSL_PBL_RCW:"%"=%) \
> -R $(srctree)/$(CONFIG_SYS_FSL_PBL_PBI:"%"=%) -T pblimage
>
> -u-boot.img u-boot.kwb u-boot.pbl: u-boot.bin FORCE
> +u-boot.img u-boot.kwb u-boot.pbl: u-boot$(if $(CONFIG_OF_SEPARATE),-dtb,).bin FORCE
> $(call if_changed,mkimage)
The second comma in '(if $(CONFIG_OF_SEPARATE),-dtb,)' is redundant.
This is duplicating the same image as u-boot-dtb.img
Your way is that "u-boot.img" includes DTB in some time and doesn't in the other.
I am not sure which way is better.
But we don't need two rules to generate the equivalent image.
If you go along with this change, I think it's OK with me.
Please consider removing below in that case:
ifeq ($(CONFIG_SPL_FRAMEWORK),y)
ALL-$(CONFIG_OF_SEPARATE) += u-boot-dtb.img
endif
and
u-boot-dtb.img: u-boot-dtb.bin FORCE
$(call if_changed,mkimage)
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-06-10 5:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 4:04 [U-Boot] [PATCH v3 0/14] Minor improvements to secure boot and enable on beaglebone Simon Glass
2014-06-03 4:04 ` [U-Boot] [PATCH v3 01/14] ti: am335x: Fix the U-Boot binary output Simon Glass
2014-06-11 22:17 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 02/14] cm_t335: " Simon Glass
2014-06-11 22:17 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 03/14] mx31ads: " Simon Glass
2014-06-11 22:17 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 04/14] Check that u-boot.bin size looks correct Simon Glass
2014-06-03 4:04 ` [U-Boot] [PATCH v3 05/14] am33xx/omap: Allow cache enable for all Sitara/OMAP Simon Glass
2014-06-11 22:17 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 06/14] hash: Export the function to show a hash Simon Glass
2014-06-11 22:17 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 07/14] fdt: Add DEV_TREE_BIN option to specify a device tree binary file Simon Glass
2014-06-10 5:59 ` Masahiro Yamada [this message]
2014-06-11 22:18 ` Tom Rini
2014-06-12 4:44 ` Simon Glass
2014-06-11 22:25 ` Simon Glass
2014-06-11 22:17 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 08/14] fdt: Update functions which write to an FDT to return -ENOSPC Simon Glass
2014-06-11 22:17 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 09/14] Improve error handling in fit_common Simon Glass
2014-06-11 22:18 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 10/14] mkimage: Automatically make space in FDT when full Simon Glass
2014-06-11 22:18 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 11/14] arm: ti: Increase malloc size to 16MB for armv7 boards Simon Glass
2014-06-11 22:18 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 12/14] am33xx/omap: Enable CONFIG_OF_CONTROL Simon Glass
2014-06-11 22:18 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 13/14] am33xx/omap: Enable FIT support Simon Glass
2014-06-11 22:18 ` [U-Boot] [U-Boot,v3,13/14] " Tom Rini
2014-06-03 4:04 ` [U-Boot] [PATCH v3 14/14] am33xx/omap: Add a new board to enable verified boot Simon Glass
2014-06-11 22:18 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-06-11 22:18 ` [U-Boot] [PATCH v3 0/14] Minor improvements to secure boot and enable on beaglebone Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610145923.95FF.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox