From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Refactoring of U-Boot directory structure
Date: Thu, 12 Jun 2014 06:41:45 +0200 [thread overview]
Message-ID: <20140612044145.B1CF3380601@gemini.denx.de> (raw)
In-Reply-To: <20140612131050.963A.AA925319@jp.panasonic.com>
Dear Masahiro,
In message <20140612131050.963A.AA925319@jp.panasonic.com> you wrote:
>
> [1] Do not split the similar SoC family to various directories
>
> at91 SoC directory exists under arm920t, arm926ejs, armv7 directory.
To me this actually makes sense, as they are using different CPU cores
(ARMv4t vs. ARMv5te vs. ARMv7).
> ./arch/arm/cpu/arm920t/at91
> ./arch/arm/cpu/arm926ejs/at91
> ./arch/arm/cpu/armv7/at91
>
> It looks reasonable to collect at91 sources into a single place,
> arch/arm/mach-at91
Did you look at the code? Files like lowlevel_init.S, reset.c or
timer.c look pretty much specific to the respective architecture.
What would be the benefit of mixing all this different stuff in a
single directory?
> That's why Tegra directories are sprinkled under arch/arm/:
>
> arch/arm/cpu/arm720t/tegra-common/
> arch/arm/cpu/arm720t/tegra20/
> arch/arm/cpu/arm720t/tegra30/
> arch/arm/cpu/arm720t/tegra114/
> arch/arm/cpu/arm720t/tegra124/
> arch/arm/cpu/armv7/tegra-common/
> arch/arm/cpu/armv7/tegra20/
> arch/arm/cpu/armv7/tegra30/
> arch/arm/cpu/armv7/tegra114/
> arch/arm/cpu/armv7/tegra124/
> arch/arm/include/asm/arch-tegra/
> arch/asm/include/asm/arch-tegra20/
> arch/asm/include/asm/arch-tegra30/
> arch/asm/include/asm/arch-tegra114/
> arch/asm/include/asm/arch-tegra124/
>
>
> They can be refactored
>
> arch/arm/mach-tegra/ : tegra common part
> arch/arm/mach-tegra/tegra20/ : tegra20-specific
> arch/arm/mach-tegra/tegra30/ : tegra30-specific
> arch/arm/mach-tegra/tegra114/ : tegra114-specific
> arch/arm/mach-tegra/tegra124/ : tegra124-specific
Again, we have different CPU cores here, and thus pretty much
different code - what would be the benefit of mixing unrelated code
in a single directory?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Boykottiert Microsoft - Kauft Eure Fenster bei OBI!
next prev parent reply other threads:[~2014-06-12 4:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 4:10 [U-Boot] Refactoring of U-Boot directory structure Masahiro Yamada
2014-06-12 4:41 ` Wolfgang Denk [this message]
2014-06-12 6:32 ` Masahiro Yamada
2014-06-12 7:46 ` Andreas Bießmann
2014-06-12 15:16 ` Stephen Warren
2014-06-13 7:18 ` Masahiro Yamada
2014-07-28 3:31 ` Simon Glass
2014-07-28 17:24 ` Stephen Warren
2014-07-28 3:26 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612044145.B1CF3380601@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox