From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 13 Jun 2014 09:40:33 -0400 Subject: [U-Boot] [PATCH] fs/fat: add a parameter: allow_whole_dev to fat_register_device() In-Reply-To: <539A70FF.4080003@atmel.com> References: <1402552643-13297-1-git-send-email-josh.wu@atmel.com> <20140612062648.E79553803E2@gemini.denx.de> <53995100.9080307@atmel.com> <20140612085240.6E953380133@gemini.denx.de> <539A70FF.4080003@atmel.com> Message-ID: <20140613134033.GD5752@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jun 13, 2014 at 11:33:19AM +0800, Josh Wu wrote: > Dear Wolfgang > > On 6/12/2014 4:52 PM, Wolfgang Denk wrote: > >Dear Josh Wu, > > > >In message <53995100.9080307@atmel.com> you wrote: I will read and think about the rest of this, but: [snip] > >>>>+int fat_register_device(block_dev_desc_t *dev_desc, int part_no, > >>>>+ bool allow_whole_dev); > >>>Please make this an "int" type, and use 0 and 1. > >>Is there any special concern for that? like cause machine compatiable issue? > >Boolean values in C are 1 and 0. Hiding these under other names (like > >"true" and "false") doesn't buy anything. > > Okay. I just think use bool will be more readable. That also can > make people less use an integer number, which in some case it's hard > to understand it. We have bool and make use of bool when things are a boolean, your way here is fine. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: