[U-Boot] [PATCH] fs/fat: add a parameter: allow_whole_dev to fat_register_device()

Wolfgang Denk
2014-06-12T06:26:48Z

Dear Josh Wu,

In message <1402552643-13297-1-git-send-email-josh.wu@atmel.com> you wrote:
> For SPL in FAT and envrionment load/save in FAT, to support no partition
> table device (whole device is FAT partition). We need specify the partition
> number as 0.

Sorry, I cannot parse this. What exactly do you mean here?

> But in FAT SPL and environment case, when we specify the partition number as
> 1, it is reasonable to support the device has no partition table and only a
> FAT partition.

Why would the expectations in SPL be different from other use cases?

> +int fat_register_device(block_dev_desc_t *dev_desc, int part_no,
> + bool allow_whole_dev);

Please make this an "int" type, and use 0 and 1.

Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Wright Bothers weren't the first to fly. They were just the first
not to crash.