public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch 1/7] Add TQ Systems TQMa6 board support
Date: Mon, 16 Jun 2014 14:41:48 +0200	[thread overview]
Message-ID: <20140616124148.E21293804AA@gemini.denx.de> (raw)
In-Reply-To: <1402915858-1335-2-git-send-email-list-09_u-boot@tqsc.de>

Dear Markus Niebel,

In message <1402915858-1335-2-git-send-email-list-09_u-boot@tqsc.de> you wrote:
> 
> This patch adds the changes to boards.cfg and the board directory
> under board/tqc.

...
> +#define CONFIG_EXTRA_ENV_SETTINGS                                              \
...
> +	"baudrate="__stringify(CONFIG_BAUDRATE)"\0"                            \

"baudrate" is already in the standard settings.  You just create a
duplicated entry here.

...
> +/* Print Buffer Size */
> +#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)

WARNING: line over 80 characters
#1067: FILE: include/configs/tqma6.h:190:
+#define CONFIG_SYS_PBSIZE              (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The important thing about being a leader is not being right or wrong,
but being *certain*.                    - Terry Pratchett, _Truckers_

  reply	other threads:[~2014-06-16 12:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 10:50 [U-Boot] [Patch 0/7] Add support for TQMa6 modules Markus Niebel
2014-06-16 10:50 ` [U-Boot] [Patch 1/7] Add TQ Systems TQMa6 board support Markus Niebel
2014-06-16 12:41   ` Wolfgang Denk [this message]
2014-06-16 15:01     ` Markus Niebel
2014-06-16 10:50 ` [U-Boot] [Patch 2/7] TQMa6: mba6: add RGMII enet Markus Niebel
2014-06-16 10:50 ` [U-Boot] [Patch 3/7] TQMa6: add SPI support Markus Niebel
2014-06-16 10:50 ` [U-Boot] [Patch 4/7] TQMa6: add SPI NOR boot support Markus Niebel
2014-06-16 10:50 ` [U-Boot] [Patch 5/7] TQMa6: MBa6: add usb support Markus Niebel
2014-06-16 10:50 ` [U-Boot] [Patch 6/7] TQMa6: add I2C support Markus Niebel
2014-06-16 10:50 ` [U-Boot] [Patch 7/7] TQMa6: add pmic support Markus Niebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140616124148.E21293804AA@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox