public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Avoid using gawk-specific strtonum()
Date: Wed, 18 Jun 2014 12:01:12 +0200	[thread overview]
Message-ID: <20140618100112.846EC383169@gemini.denx.de> (raw)
In-Reply-To: <1403071815-32055-1-git-send-email-sjg@chromium.org>

Dear Simon,

In message <1403071815-32055-1-git-send-email-sjg@chromium.org> you wrote:
> We need to subtract two hex numbers. Avoid using strtonum() by doing the
> subtraction in bc with a suitable input base.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reported-by: Vasili Galka <vvv444@gmail.com>
> ---
> 
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 24d9687..bb2f615 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -788,7 +788,8 @@ OBJCOPYFLAGS_u-boot.bin := -O binary
>  binary_size_check: u-boot.bin System.map FORCE
>  	@file_size=`stat -c %s u-boot.bin` ; \
>  	map_size=$(shell cat System.map | \
> -		awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print strtonum("0x" end) - strtonum("0x" start)}'); \
> +		awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
> +		| bc); \

I think instead of introducing yet another tool dependency this could
be rewritten to use just bash:

	awk '/_image_copy_start/ {start = $1}
	     /_image_binary_end/ {end = $1}
	     END { if (start != "" && end != "")
	     	print "printf %d $$((0x" end " - 0x" start "))"
	     }' |
	bash

?



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  What's a light-year?
A:  One-third less calories than a regular year.

  reply	other threads:[~2014-06-18 10:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  6:10 [U-Boot] [PATCH] Avoid using gawk-specific strtonum() Simon Glass
2014-06-18 10:01 ` Wolfgang Denk [this message]
2014-06-18 18:26   ` Tom Rini
2014-06-18 18:38     ` Jeroen Hofstee
2014-06-18 19:14     ` Simon Glass
2014-06-18 19:32       ` Tom Rini
2014-06-18 20:34     ` Måns Rullgård
2014-07-08  1:36 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140618100112.846EC383169@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox