public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test: dfu: script enhancements
Date: Fri, 20 Jun 2014 18:00:34 +0200	[thread overview]
Message-ID: <20140620180034.46546af9@amdc2363> (raw)
In-Reply-To: <1402439290-32731-1-git-send-email-swarren@wwwdotorg.org>

Hi Stephen,

> From: Stephen Warren <swarren@nvidia.com>
> 
> Various misc enhancements to dfu_gadget_test.sh:
> 
> * After every write (download), perform a write to a different file
>   with different data. This ensures that the DFU buffer's content is
>   replaced, so that if the read (upload) succeeds, we know that the
>   correct data was actually read from the storage device, rather than
>   simply being left over in the DFU buffer. This requires two alt
>   setting names to be passed to the script, and a dummy data file to
>   be generated by dfu_gadget_test_init.sh.
> 
> * Fix the assumption that dfu_gadget_test.sh is run from the directory
>   that contains it, by cd'ing to that directory before invoking
>   ./dfu_gadget_test_init.sh.
> 
> * Use $DIR$RCV_DIR consistently, rather than using plain $RCV_DIR in
>   some places.
> 
> * Add 959, 961 test file sizes, to be consistent with having one
>   more than and one less than all the other "round" sizes 64, 128, and
>   4096.
> 
> * Remove references to $BKP_DIR from dfu_gadget_test_init.sh, since it
>   isn't used.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Applied to u-boot-dfu

[Although, I've also added an incremental patch with some README
clarification]

Stephen, thanks for enhancements.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  parent reply	other threads:[~2014-06-20 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 22:28 [U-Boot] [PATCH] test: dfu: script enhancements Stephen Warren
2014-06-12  9:51 ` Lukasz Majewski
2014-06-12 15:29   ` Stephen Warren
2014-06-20 16:00 ` Lukasz Majewski [this message]
2014-06-20 16:05   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140620180034.46546af9@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox