* [U-Boot] [PATCH] thor: defer parsing of device string to IO backend
@ 2014-06-20 7:35 Lukasz Majewski
2014-06-20 15:56 ` Stephen Warren
2014-06-23 7:39 ` [U-Boot] [PATCH v2] " Lukasz Majewski
0 siblings, 2 replies; 8+ messages in thread
From: Lukasz Majewski @ 2014-06-20 7:35 UTC (permalink / raw)
To: u-boot
This commit adjust thor downloading function to work correctly with deferred
device string parsing.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
common/cmd_thordown.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c
index 2dd7509..8ed1dc6 100644
--- a/common/cmd_thordown.c
+++ b/common/cmd_thordown.c
@@ -26,10 +26,9 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
puts("TIZEN \"THOR\" Downloader\n");
- ret = dfu_init_env_entities(interface, simple_strtoul(devstring,
- NULL, 10));
+ ret = dfu_init_env_entities(interface, devstring);
if (ret)
- return ret;
+ goto done;
int controller_index = simple_strtoul(usb_controller, NULL, 0);
ret = board_usb_init(controller_index, USB_INIT_DEVICE);
@@ -57,6 +56,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
exit:
g_dnl_unregister();
+done:
dfu_free_entities();
return ret;
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] thor: defer parsing of device string to IO backend
2014-06-20 7:35 [U-Boot] [PATCH] thor: defer parsing of device string to IO backend Lukasz Majewski
@ 2014-06-20 15:56 ` Stephen Warren
2014-06-23 7:39 ` [U-Boot] [PATCH v2] " Lukasz Majewski
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2014-06-20 15:56 UTC (permalink / raw)
To: u-boot
On 06/20/2014 01:35 AM, Lukasz Majewski wrote:
> This commit adjust thor downloading function to work correctly with deferred
> device string parsing.
Oops. I should have grep'd for more users of dfu_init_env_entities() and
fixed them up in my commit.
==========
Since this patch also changes behaviour when that function fails, so the
partially parsed entries are freed too, I'd re-write the whole commit
description as:
Comit XXXXX "dfu: defer parsing of device string to IO backend" changed
the function signature of dfu_init_env_entities(). Adjust cmd_thordown.c
to match that change.
Also, apply the same change as commit XXXXX "dfu: free entities when
parsing fails" to cmd_thordown.c.
Fixes: XXXXX ("dfu: defer parsing of device string to IO backend")
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
==========
But either way,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCH v2] thor: defer parsing of device string to IO backend
2014-06-20 7:35 [U-Boot] [PATCH] thor: defer parsing of device string to IO backend Lukasz Majewski
2014-06-20 15:56 ` Stephen Warren
@ 2014-06-23 7:39 ` Lukasz Majewski
2014-06-23 7:39 ` Lukasz Majewski
2014-06-23 19:02 ` Stephen Warren
1 sibling, 2 replies; 8+ messages in thread
From: Lukasz Majewski @ 2014-06-23 7:39 UTC (permalink / raw)
To: u-boot
Commit d4f5ef59cc7 "dfu: defer parsing of device string to IO backend" changed
the function signature of dfu_init_env_entities(). Adjust cmd_thordown.c
to match that change.
Also, apply the same change as commit d6d37d737b58e "dfu: free entities
when parsing fails" to cmd_thordown.c.
Fixes: d4f5ef59cc7 ("dfu: defer parsing of device string to IO backend")
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
common/cmd_thordown.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c
index 96f7d32..27927ba 100644
--- a/common/cmd_thordown.c
+++ b/common/cmd_thordown.c
@@ -26,10 +26,9 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
puts("TIZEN \"THOR\" Downloader\n");
- ret = dfu_init_env_entities(interface, simple_strtoul(devstring,
- NULL, 10));
+ ret = dfu_init_env_entities(interface, devstring);
if (ret)
- return ret;
+ goto done;
int controller_index = simple_strtoul(usb_controller, NULL, 0);
ret = board_usb_init(controller_index, USB_INIT_DEVICE);
@@ -57,6 +56,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
exit:
g_dnl_unregister();
+done:
dfu_free_entities();
return ret;
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH v2] thor: defer parsing of device string to IO backend
2014-06-23 7:39 ` [U-Boot] [PATCH v2] " Lukasz Majewski
@ 2014-06-23 7:39 ` Lukasz Majewski
2014-06-23 8:36 ` Marek Vasut
2014-06-23 19:02 ` Stephen Warren
1 sibling, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2014-06-23 7:39 UTC (permalink / raw)
To: u-boot
Commit d4f5ef59cc7 "dfu: defer parsing of device string to IO backend" changed
the function signature of dfu_init_env_entities(). Adjust cmd_thordown.c
to match that change.
Also, apply the same change as commit d6d37d737b58e "dfu: free entities
when parsing fails" to cmd_thordown.c.
Fixes: d4f5ef59cc7 ("dfu: defer parsing of device string to IO backend")
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
common/cmd_thordown.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c
index 96f7d32..27927ba 100644
--- a/common/cmd_thordown.c
+++ b/common/cmd_thordown.c
@@ -26,10 +26,9 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
puts("TIZEN \"THOR\" Downloader\n");
- ret = dfu_init_env_entities(interface, simple_strtoul(devstring,
- NULL, 10));
+ ret = dfu_init_env_entities(interface, devstring);
if (ret)
- return ret;
+ goto done;
int controller_index = simple_strtoul(usb_controller, NULL, 0);
ret = board_usb_init(controller_index, USB_INIT_DEVICE);
@@ -57,6 +56,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
exit:
g_dnl_unregister();
+done:
dfu_free_entities();
return ret;
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH v2] thor: defer parsing of device string to IO backend
2014-06-23 7:39 ` Lukasz Majewski
@ 2014-06-23 8:36 ` Marek Vasut
2014-06-23 10:40 ` Lukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2014-06-23 8:36 UTC (permalink / raw)
To: u-boot
On Monday, June 23, 2014 at 09:39:16 AM, Lukasz Majewski wrote:
> Commit d4f5ef59cc7 "dfu: defer parsing of device string to IO backend"
> changed the function signature of dfu_init_env_entities(). Adjust
> cmd_thordown.c to match that change.
>
> Also, apply the same change as commit d6d37d737b58e "dfu: free entities
> when parsing fails" to cmd_thordown.c.
>
> Fixes: d4f5ef59cc7 ("dfu: defer parsing of device string to IO backend")
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Did this go out twice ? What's the V2 changelog please ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCH v2] thor: defer parsing of device string to IO backend
2014-06-23 8:36 ` Marek Vasut
@ 2014-06-23 10:40 ` Lukasz Majewski
0 siblings, 0 replies; 8+ messages in thread
From: Lukasz Majewski @ 2014-06-23 10:40 UTC (permalink / raw)
To: u-boot
Hi Marek,
> On Monday, June 23, 2014 at 09:39:16 AM, Lukasz Majewski wrote:
> > Commit d4f5ef59cc7 "dfu: defer parsing of device string to IO
> > backend" changed the function signature of dfu_init_env_entities().
> > Adjust cmd_thordown.c to match that change.
> >
> > Also, apply the same change as commit d6d37d737b58e "dfu: free
> > entities when parsing fails" to cmd_thordown.c.
> >
> > Fixes: d4f5ef59cc7 ("dfu: defer parsing of device string to IO
> > backend")
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Did this go out twice ?
I hope it didn't :-)
> What's the V2 changelog please ?
My bad - I wanted to send it ASAP :-)
The v2 was just a complete rewrite of the v1's commit message as it was
suggested by Stephen.
No code change was done.
>
> Best regards,
> Marek Vasut
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] thor: defer parsing of device string to IO backend
2014-06-23 7:39 ` [U-Boot] [PATCH v2] " Lukasz Majewski
2014-06-23 7:39 ` Lukasz Majewski
@ 2014-06-23 19:02 ` Stephen Warren
2014-06-25 7:07 ` Lukasz Majewski
1 sibling, 1 reply; 8+ messages in thread
From: Stephen Warren @ 2014-06-23 19:02 UTC (permalink / raw)
To: u-boot
On 06/23/2014 01:39 AM, Lukasz Majewski wrote:
> Commit d4f5ef59cc7 "dfu: defer parsing of device string to IO backend" changed
> the function signature of dfu_init_env_entities(). Adjust cmd_thordown.c
> to match that change.
>
> Also, apply the same change as commit d6d37d737b58e "dfu: free entities
> when parsing fails" to cmd_thordown.c.
>
> Fixes: d4f5ef59cc7 ("dfu: defer parsing of device string to IO backend")
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Both the fixes and s-o-b tag should be in the same final paragraph with
no blank lines between. I assume that can be easily fixed up when applying.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCH v2] thor: defer parsing of device string to IO backend
2014-06-23 19:02 ` Stephen Warren
@ 2014-06-25 7:07 ` Lukasz Majewski
0 siblings, 0 replies; 8+ messages in thread
From: Lukasz Majewski @ 2014-06-25 7:07 UTC (permalink / raw)
To: u-boot
Hi Stephen,
> On 06/23/2014 01:39 AM, Lukasz Majewski wrote:
> > Commit d4f5ef59cc7 "dfu: defer parsing of device string to IO
> > backend" changed the function signature of dfu_init_env_entities().
> > Adjust cmd_thordown.c to match that change.
> >
> > Also, apply the same change as commit d6d37d737b58e "dfu: free
> > entities when parsing fails" to cmd_thordown.c.
> >
> > Fixes: d4f5ef59cc7 ("dfu: defer parsing of device string to IO
> > backend")
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Both the fixes and s-o-b tag should be in the same final paragraph
> with no blank lines between. I assume that can be easily fixed up
> when applying.
>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
Applied to u-boot-dfu,
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-06-25 7:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-20 7:35 [U-Boot] [PATCH] thor: defer parsing of device string to IO backend Lukasz Majewski
2014-06-20 15:56 ` Stephen Warren
2014-06-23 7:39 ` [U-Boot] [PATCH v2] " Lukasz Majewski
2014-06-23 7:39 ` Lukasz Majewski
2014-06-23 8:36 ` Marek Vasut
2014-06-23 10:40 ` Lukasz Majewski
2014-06-23 19:02 ` Stephen Warren
2014-06-25 7:07 ` Lukasz Majewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox