public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x
Date: Wed, 25 Jun 2014 15:50:17 +0200	[thread overview]
Message-ID: <201406251550.18009.marex@denx.de> (raw)
In-Reply-To: <CAOf5uwkw9O8SEGjyk8n=kzX_5qJvi5ysCyQXqgr+jO2t00Q9Xg@mail.gmail.com>

On Tuesday, June 24, 2014 at 04:38:58 PM, Michael Trimarchi wrote:
[...]
> > index af46db2..f78d532 100644
> > --- a/drivers/usb/phy/omap_usb_phy.c
> > +++ b/drivers/usb/phy/omap_usb_phy.c
> > @@ -222,7 +222,22 @@ static void am437x_enable_usb2_phy2(struct omap_xhci
> 
> *omap)
> 
> >  void usb_phy_power(int on)
> >  {
> > 
> > -       return;
> > +       u32 val;
> > +
> > +       /* USB1_CTRL */
> > +       val = readl(USB1_CTRL);
> > +       if (on) {
> > +               /*
> > +                * these bits are re-used on AM437x to power up/down the
> 
> USB
> 
> > +                * CM and OTG PHYs, if we don't toggle them, USB will not
> 
> be
> 
> > +                * functional on newer silicon revisions
> > +                */
> > +               val &= ~(USB1_CTRL_CM_PWRDN | USB1_CTRL_OTG_PWRDN);
> > +       } else {
> > +               val |= USB1_CTRL_CM_PWRDN | USB1_CTRL_OTG_PWRDN;
> > +       }
> > +
> > +       writel(val, USB1_CTRL);

Thanks, please use clrbits_le32() and setbits_le32() here instead.

Best regards,
Marek Vasut

  reply	other threads:[~2014-06-25 13:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 21:25 [U-Boot] [PATCH 1/2] usb: host: xhci: make sure to power up PHY Felipe Balbi
2014-06-23 21:25 ` [U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x Felipe Balbi
2014-06-23 21:28   ` Michael Trimarchi
2014-06-23 21:58     ` Felipe Balbi
2014-06-23 22:02       ` Michael Trimarchi
2014-06-23 22:18         ` [U-Boot] [PATCH v2 " Felipe Balbi
2014-06-24 14:38           ` Michael Trimarchi
2014-06-25 13:50             ` Marek Vasut [this message]
2014-07-07 16:14           ` Felipe Balbi
2014-07-07 18:08             ` Marek Vasut
2014-07-09 12:41               ` Tom Rini
2014-07-09 12:48                 ` Michael Trimarchi
2014-07-09 16:02                   ` Marek Vasut
2014-07-09 21:03           ` Marek Vasut
2014-06-27 15:27 ` [U-Boot] [PATCH 1/2] usb: host: xhci: make sure to power up PHY Dan Murphy
2014-06-27 15:36   ` Felipe Balbi
2014-06-27 15:37     ` Dan Murphy
2014-07-07 16:14 ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201406251550.18009.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox