From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 1 Jul 2014 12:17:41 +0200 Subject: [U-Boot] [PATCH V2] usb: ci_udc: Allocate the qTD list directly In-Reply-To: <53B25A81.6000208@posteo.de> References: <1404172398-6522-1-git-send-email-marex@denx.de> <1404173061-6691-1-git-send-email-marex@denx.de> <53B25A81.6000208@posteo.de> Message-ID: <201407011217.41490.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, July 01, 2014 at 08:51:45 AM, J?rg Krause wrote: > On 07/01/2014 02:04 AM, Marek Vasut wrote: > > Instead of weird allocation of ci_drv->items_mem and then even weirder > > distribution of offsets in this memory area into ci_drv->items array, > > just allocate ci_drv->items as a big slab of aligned memory (replaces > > ci_drv->items_mem) and let ci_get_qtd() do the distribution of offsets > > in this memory area. > > > > Signed-off-by: Marek Vasut > > Cc: J?rg Krause > > Cc: Stephen Warren > > --- > > > > drivers/usb/gadget/ci_udc.c | 19 ++++++------------- > > drivers/usb/gadget/ci_udc.h | 3 +-- > > 2 files changed, 7 insertions(+), 15 deletions(-) > > > > V2: Rebase on top of u-boot-usb/master instead of the research branch [...] > I made a test on u-boot-arm/master before (Test#1) and after applying > this patch (Test#2). Can we please sync on the same codebase (u-boot-usb/master) ? > After a reset I run this script: > test_usb=setenv i 64; while test ${i} -gt 0; do echo ${i}; tftp > ${rootfs_file}; setexpr i ${i} - 1; done; setenv i; > > Both tests (Test#1 and Test#2) runs fine with the script. But if I do > run tftp ${rootfs_file} manually from the console, I get the known error > starting the fourth run for both Test#1 and Test#2. Can you edit arch/arm/cpu/arm926ejs/cache.c and change the debug() to printf() , then re-test please ? I suspect this might trap something still. Ah, and please test on u-boot-usb/master with this patch. Best regards, Marek Vasut