From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 1 Jul 2014 13:19:37 +0200
Subject: [U-Boot] [PATCH V2] usb: ci_udc: Allocate the qTD list directly
In-Reply-To: <53B2957D.2030101@posteo.de>
References: <1404172398-6522-1-git-send-email-marex@denx.de>
	<201407011217.41490.marex@denx.de> <53B2957D.2030101@posteo.de>
Message-ID: <201407011319.37499.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday, July 01, 2014 at 01:03:25 PM, J?rg Krause wrote:
> On 07/01/2014 12:17 PM, Marek Vasut wrote:
> > On Tuesday, July 01, 2014 at 08:51:45 AM, J?rg Krause wrote:
> >> On 07/01/2014 02:04 AM, Marek Vasut wrote:
> >>> Instead of weird allocation of ci_drv->items_mem and then even weirder
> >>> distribution of offsets in this memory area into ci_drv->items array,
> >>> just allocate ci_drv->items as a big slab of aligned memory (replaces
> >>> ci_drv->items_mem) and let ci_get_qtd() do the distribution of offsets
> >>> in this memory area.
> >>> 
> >>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>> Cc: J?rg Krause <jkrause@posteo.de>
> >>> Cc: Stephen Warren <swarren@wwwdotorg.org>
> >>> ---
> >>> 
> >>>    drivers/usb/gadget/ci_udc.c | 19 ++++++-------------
> >>>    drivers/usb/gadget/ci_udc.h |  3 +--
> >>>    2 files changed, 7 insertions(+), 15 deletions(-)
> >>> 
> >>> V2: Rebase on top of u-boot-usb/master instead of the research branch
> > 
> > [...]
> > 
> >> I made a test on u-boot-arm/master before (Test#1) and after applying
> >> this patch (Test#2).
> > 
> > Can we please sync on the same codebase (u-boot-usb/master) ?
> 
> Sorry, this is a type. I tested on u-boot-usb/master.
> 
> >> After a reset I run this script:
> >> test_usb=setenv i 64; while test ${i} -gt 0; do echo ${i}; tftp
> >> ${rootfs_file}; setexpr i ${i} - 1; done; setenv i;
> >> 
> >> Both tests (Test#1 and Test#2) runs fine with the script. But if I do
> >> run tftp ${rootfs_file} manually from the console, I get the known error
> >> starting the fourth run for both Test#1 and Test#2.
> > 
> > Can you edit arch/arm/cpu/arm926ejs/cache.c and change the debug() to
> > printf() , then re-test please ? I suspect this might trap something
> > still. Ah, and please test on u-boot-usb/master with this patch.
> 
> No additional output on the console.

What does this mean? Do you see warning messages prefixed with "CACHE: " ?

Best regards,
Marek Vasut