From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: tegra: Add support for norrin board
Date: Tue, 1 Jul 2014 11:13:28 -0700 [thread overview]
Message-ID: <20140701181327.GA11604@nvidia.com> (raw)
In-Reply-To: <53B1D764.6010007@wwwdotorg.org>
On Mon, Jun 30, 2014 at 02:32:20PM -0700, Stephen Warren wrote:
> On 06/30/2014 02:53 PM, Allen Martin wrote:
> > Norrin (PM370) is a Tegra124 clamshell board that is very similar to
> > venice2, but it has a different panel, the sdcard cd sense is flipped,
> > and it has a different revision of the AS3722 PMIC. Reuse the venice2
> > config with a norrin dtb. This board is also refered to as "nyan" in
> > the ChromeOS trees.
>
> Isn't the pinmux different too? I think this patch should contain
> board/nvidia/norrin/pinmux-config-norrin.h shouldn't it? That in turn
> would mean adding Norrin support to tegra-pinmux-scripts. Of course, if
> they really do have 100% identical pinmux, then there's no issue. I'm
> skeptical though.
AFAIK they really do have identical pinmux, I'll double check the
pinmux spreadsheet to make sure.
There's another unintended side effect of reusing the venice2 board
this way that I discovered after posting this. It causes
CONFIG_SYS_BOARD to be set to venice2 still, which causes the
"board_name" environment variable to be set to venice2, which causes
boot.scr to look for a venice2 dtb.
It may be cleaner to make norrin a proper board, and just have it
#include the vencie2 pinmux.
-Allen
nvpublic
prev parent reply other threads:[~2014-07-01 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 20:53 [U-Boot] [PATCH] ARM: tegra: Add support for norrin board Allen Martin
2014-06-30 21:32 ` Stephen Warren
2014-07-01 18:13 ` Allen Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701181327.GA11604@nvidia.com \
--to=amartin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox