From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 13/13] fit: make sha256 support optional
Date: Thu, 3 Jul 2014 15:17:59 -0400 [thread overview]
Message-ID: <20140703191759.GI29202@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ16gFdtuS+XLwK5+GfmJzE2mbf5CNb9qUMRggyxqT4odg@mail.gmail.com>
On Thu, Jul 03, 2014 at 09:14:01AM -0700, Simon Glass wrote:
> Hi,
>
> On 3 July 2014 00:03, Heiko Schocher <hs@denx.de> wrote:
> >
> > Hello Dirk,
> >
> > Am 03.07.2014 08:27, schrieb dirk.eibach at gdsys.cc:
> >
> >> From: Dirk Eibach<dirk.eibach@gdsys.cc>
> >>
> >> sha256 has some beefy memory footprint.
> >> Make it optional for constrained systems.
> >>
> >>
> >> Signed-off-by: Dirk Eibach<dirk.eibach@gdsys.cc>
> >> ---
> >>
> >> Changes in v3: None
> >> Changes in v2:
> >> - make sha256 support optional
> >>
> >> include/configs/dlvision-10g.h | 1 +
> >> include/configs/io.h | 1 +
> >> include/configs/iocon.h | 1 +
> >> include/configs/neo.h | 1 +
> >> include/image.h | 5 +++++
> >> 5 files changed, 9 insertions(+)
> >
> >
> > Sorry, some nitpick. As you introduce here the new define "CONFIG_FIT_DISABLE_SHA256",
> > can you please add a short description in the README, thanks!
>
> I wonder if it would be better to make the option off by default? You
> could perhaps use the existing CONFIG_SHA256 option, and check in
> image.h to enable/disable support.
>
> Heiko what do you think?
I think I like this unless there's a problem...
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140703/6ae56289/attachment.pgp>
next prev parent reply other threads:[~2014-07-03 19:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 6:27 [U-Boot] [PATCH v3 0/13] Fixes on gdsys boards and some new functionality dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 01/13] board: controlcenterd: Fix pci access dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 02/13] board: gdsys: Adapt sdhc_boot.c to mmc_get_env_addr API change dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 03/13] board: controlcenterd: Use new API for setting i2c bus dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 04/13] board: iocon: Support DisplayPort hardware dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 05/13] i2c: IHS I2C master driver dirk.eibach at gdsys.cc
2014-07-03 7:01 ` Heiko Schocher
2014-07-03 6:27 ` [U-Boot] [PATCH v3 06/13] board: gdsys: Fix dlvision-10g I2C configuration dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 07/13] board: gdsys: Increase iocon and dlv10g version string dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 08/13] board: gdsys: Configure bridge on DP501 to support DDC only dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 09/13] board: gdsys: Make gdsys osd hardware detection more robust dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 10/13] board: gdsys: Enable scrambling on DP501 dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 11/13] board: iocon: Modify iocon hardware startup dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 12/13] board: gdsys: Remove commands to reduce footprint dirk.eibach at gdsys.cc
2014-07-03 6:27 ` [U-Boot] [PATCH v3 13/13] fit: make sha256 support optional dirk.eibach at gdsys.cc
2014-07-03 7:03 ` Heiko Schocher
2014-07-03 16:14 ` Simon Glass
2014-07-03 19:17 ` Tom Rini [this message]
2014-07-04 4:17 ` Heiko Schocher
2014-07-04 5:04 ` Dirk Eibach
2014-07-03 6:40 ` [U-Boot] [PATCH v3 0/13] Fixes on gdsys boards and some new functionality Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703191759.GI29202@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox