From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 4 Jul 2014 16:59:27 +0200 Subject: [U-Boot] [PATCH 2/5] board_r: run scsi init() on ARM too In-Reply-To: <1401554175-29599-2-git-send-email-ijc@hellion.org.uk> References: <1401554145.15871.100.camel@hastur.hellion.org.uk> <1401554175-29599-2-git-send-email-ijc@hellion.org.uk> Message-ID: <201407041659.27389.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday, May 31, 2014 at 06:36:12 PM, Ian Campbell wrote: > This has been disabled for ARM in initr_scsi since that function was > introduced. However it works fine for me on Cubieboard and Cubietruck (with > the upcoming AHCI glue patch). Does this break bisectability ? > I also tested on two random ARM platforms which seem to define > CONFIG_CMD_SCSI: - highbank worked fine (on midway hardware) > - omap5_uevm built OK and I confirmed using objdump that things were as > expected (i.e. the default weak scsi_init nop was used). > > While there remove the mismatched comment from the #endif (omitting the > comment seems to be the prevailing style in this file) and add a missing > return to initr_doc which I happened to spot while editing. > > Signed-off-by: Ian Campbell > Cc: Simon Glass Make sure to check no ARM boards call scsi_init() from their board files. Best regards, Marek Vasut