public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] board_r: run scsi init() on ARM too
Date: Fri, 4 Jul 2014 17:44:21 +0200	[thread overview]
Message-ID: <201407041744.21727.marex@denx.de> (raw)
In-Reply-To: <1404487510.14796.38.camel@kazak.uk.xensource.com>

On Friday, July 04, 2014 at 05:25:10 PM, Ian Campbell wrote:
> On Fri, 2014-07-04 at 16:59 +0200, Marek Vasut wrote:
> > On Saturday, May 31, 2014 at 06:36:12 PM, Ian Campbell wrote:
> > > This has been disabled for ARM in initr_scsi since that function was
> > > introduced. However it works fine for me on Cubieboard and Cubietruck
> > > (with the upcoming AHCI glue patch).
> > 
> > Does this break bisectability ?
> 
> Not if this patch goes in first.
> 
> > > I also tested on two random ARM platforms which seem to define
> > > CONFIG_CMD_SCSI: - highbank worked fine (on midway hardware)
> > > 
> > >  - omap5_uevm built OK and I confirmed using objdump that things were
> > >  as
> > >  
> > >    expected (i.e. the default weak scsi_init nop was used).
> > > 
> > > While there remove the mismatched comment from the #endif (omitting the
> > > comment seems to be the prevailing style in this file) and add a
> > > missing return to initr_doc which I happened to spot while editing.
> > > 
> > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > > Cc: Simon Glass <sjg@chromium.org>
> > 
> > Make sure to check no ARM boards call scsi_init() from their board files.
> 
> I grepped around and couldn't find any.

OK, thanks!

Best regards,
Marek Vasut

  reply	other threads:[~2014-07-04 15:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 16:35 [U-Boot] [PATCH 0/5] sunxi: GPIO, AHCI and Cubieboard 2 support Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms Ian Campbell
2014-07-04 14:58   ` Marek Vasut
2014-07-04 15:26     ` Ian Campbell
2014-07-04 15:44       ` Marek Vasut
2014-07-04 16:16         ` Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 2/5] board_r: run scsi init() on ARM too Ian Campbell
2014-06-03  3:32   ` Simon Glass
2014-07-04 14:59   ` Marek Vasut
2014-07-04 15:25     ` Ian Campbell
2014-07-04 15:44       ` Marek Vasut [this message]
2014-05-31 16:36 ` [U-Boot] [PATCH 3/5] sunxi: add Cubieboard2 support Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 4/5] sunxi: add gpio driver Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 5/5] ahci: provide sunxi SATA driver using AHCI platform framework Ian Campbell
2014-06-03 19:49   ` Hans de Goede
2014-06-04  8:37     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201407041744.21727.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox