From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxin B. John Date: Mon, 7 Jul 2014 15:17:10 +0200 Subject: [U-Boot] [PATCH] mtdcore: Fix a build error with CONFIG_CMD_MTDPARTS_SPREAD In-Reply-To: <20140707121709.DCC68383356@gemini.denx.de> References: <1404729444-10957-1-git-send-email-maxin.john@enea.com> <20140707121709.DCC68383356@gemini.denx.de> Message-ID: <20140707131710.GA14901@sestofb10.enea.se> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, On Mon, Jul 07, 2014 at 02:17:09PM +0200, Wolfgang Denk wrote: > Dear Maxin, > > In message <1404729444-10957-1-git-send-email-maxin.john@enea.com> you wrote: > > This patch fixes the build error for CONFIG_CMD_MTDPARTS_SPREAD > > introduced by the commit: > > > > commit dfe64e2c89731a3f9950d7acd8681b68df2bae03 > > Author: Sergey Lapin > > Date: Mon Jan 14 03:46:50 2013 +0000 > > > > mtd: resync with Linux-3.7.1 > > Can you please check if this patch is still needed with the updated > MTD code posted by Heiko [1] - and if so, rebase your patch against > Heiko's code base? > > Thanks. > > [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/189358 Thank you very much for pointing this out. I have tested Heiko's code available here: repo: git://git.denx.de/u-boot-testing.git branch: update-v3-mtd+ubi-linux-v3.14 The build error that was mentioned in this mail is still valid there: LD drivers/pcmcia/built-in.o drivers/mtd/mtdcore.c: In function 'mtd_get_len_incl_bad': drivers/mtd/mtdcore.c:805:10: error: 'struct mtd_info' has no member named 'block_isbad' drivers/mtd/mtdcore.c:821:11: error: 'struct mtd_info' has no member named 'block_isbad' CC drivers/rtc/date.o make[1]: *** [drivers/mtd/mtdcore.o] Error 1 make: *** [drivers/mtd] Error 2 make: *** Waiting for unfinished jobs.... Also re-created patch against this. Should I send it as a separate patch or would you suggest another branch for this fix ? > > Best regards, > Wolfgang Denk Best Regards, Maxin B. John