From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements
Date: Mon, 7 Jul 2014 12:47:02 -0400 [thread overview]
Message-ID: <20140707164702.GN29202@bill-the-cat> (raw)
In-Reply-To: <1404745842.30778.37.camel@kazak.uk.xensource.com>
On Mon, Jul 07, 2014 at 04:10:42PM +0100, Ian Campbell wrote:
> On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote:
> > AFAIK we will never define both EMAC and GMAC for the same board,
>
> If we are sure of this (and I suspect this is the case, since IIRC they
> share some pins) then I agree with your suggestion.
>
> > so IMHO a better fix would be to change this line:
> >
> > rc = sunxi_emac_initialize(bis);
> >
> > to:
> >
> > int rc = sunxi_emac_initialize(bis);
That's not how we like things to look however when we can help it. Just
toss a __maybe_unused in front of the declaration (and make sure we have
<linux/compiler.h> included.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140707/5ddad13c/attachment.pgp>
next prev parent reply other threads:[~2014-07-07 16:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 9:36 [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements Hans de Goede
2014-06-09 9:36 ` [U-Boot] [PATCH v3 01/10] sunxi: mksunxiboot: Fix loading of files with a size which is not a multiple of 4 Hans de Goede
2014-06-09 9:36 ` [U-Boot] [PATCH v3 02/10] sunxi: Fix u-boot-spl.lds to refer to .vectors Hans de Goede
2014-06-09 9:36 ` [U-Boot] [PATCH v3 03/10] sunxi: Remove mmc DMA support Hans de Goede
2014-07-23 17:35 ` Siarhei Siamashka
2014-07-26 13:07 ` Hans de Goede
2014-06-09 9:36 ` [U-Boot] [PATCH v3 04/10] sunxi: Implement reset_cpu Hans de Goede
2014-07-23 17:45 ` Siarhei Siamashka
2014-07-26 13:09 ` Hans de Goede
2014-06-09 9:36 ` [U-Boot] [PATCH v3 05/10] sunxi: Add sun4i support Hans de Goede
2014-07-23 17:53 ` Siarhei Siamashka
2014-06-09 9:36 ` [U-Boot] [PATCH v3 06/10] sunxi: Add sun5i support Hans de Goede
2014-07-23 18:02 ` Siarhei Siamashka
2014-07-26 13:11 ` Hans de Goede
2014-06-09 9:36 ` [U-Boot] [PATCH v3 07/10] net: Rename and cleanup sunxi (Allwinner) emac driver Hans de Goede
2014-07-23 18:12 ` Siarhei Siamashka
2014-07-26 13:21 ` Hans de Goede
2014-07-26 13:31 ` Stefan Roese
2014-06-09 9:37 ` [U-Boot] [PATCH v3 08/10] sunxi: Add emac glue, enable emac on the cubieboard Hans de Goede
2014-07-23 18:18 ` Siarhei Siamashka
2014-06-09 9:37 ` [U-Boot] [PATCH v3 09/10] sunxi: Add support for using MII phy-s with the GMAC nic Hans de Goede
2014-07-23 18:20 ` Siarhei Siamashka
2014-06-09 9:37 ` [U-Boot] [PATCH v3 10/10] sunxi: Add Ian Campbell and Hans de Goede as cubietruck board-maintainers Hans de Goede
2014-06-25 19:57 ` [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements Ian Campbell
2014-06-26 7:38 ` Ian Campbell
2014-06-27 8:20 ` Stefan Roese
2014-07-06 19:12 ` Ian Campbell
2014-07-06 19:18 ` Albert ARIBAUD
2014-07-06 19:22 ` Ian Campbell
2014-07-06 20:54 ` Albert ARIBAUD
2014-07-06 21:28 ` Ian Campbell
2014-07-07 4:41 ` Wolfgang Denk
2014-07-07 12:50 ` Hans de Goede
2014-07-07 15:10 ` Ian Campbell
2014-07-07 16:47 ` Tom Rini [this message]
2014-07-07 20:23 ` Ian Campbell
2014-07-07 20:45 ` Tom Rini
2014-07-08 7:23 ` Ian Campbell
2014-07-08 13:48 ` Tom Rini
2014-07-08 7:48 ` Hans de Goede
2014-07-06 19:26 ` Ian Campbell
2014-07-07 12:53 ` Hans de Goede
2014-07-07 13:06 ` Tom Rini
2014-07-07 15:13 ` Ian Campbell
2014-07-08 7:47 ` Hans de Goede
2014-07-09 8:00 ` Ian Campbell
2014-07-09 8:44 ` Hans de Goede
2014-07-09 13:03 ` Henrik Nordström
2014-07-09 13:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707164702.GN29202@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox