public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6] arm: ep9315: Return back Cirrus Logic EDB9315A board support
Date: Mon, 07 Jul 2014 19:57:55 +0900	[thread overview]
Message-ID: <20140707195754.4481.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <E1X3Brq-0002AW-Vd@janus>

Hi. Sergey, Arbert.


On Sat, 5 Jul 2014 00:22:05 +0200
Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:

> Hi Sergey,
> 
> On Wed, 25 Jun 2014 23:44:29 +0400, Sergey Kostanbev
> <sergey.kostanbaev@gmail.com> wrote:
> 
> > This patch returns back support for old ep93xx processors family
> > 
> > Signed-off-by: Sergey Kostanbaev <sergey.kostanbaev@gmail.com>
> > Cc: albert.u.boot at aribaud.net
> > ---
[snip]
> 
> Applied to u-boot-arm/master, thanks!
> 
> Amicalement,
> -- 
> Albert.




I have two questions:

[1] Is this board really working?

This patch added a linker script
board/cirrus/edb93xx/u-boot.lds

But '.vectors' section is missing from it.

In my understanding, commit 41623c91b0 expects '.vectors'
section handling for all ARM linker scripts.


[2] Why was board/cirrus/edb93xx/u-boot.lds added
instead of re-using (or modifying) arch/arm/cpu/arm920t/ep93xx/u-boot.lds ?


'edb9315a' is the only one board with 'ep93xx' SoC.

It means, if you add 'board/cirrus/edb93xx/u-boot.lds',
'arch/arm/cpu/arm920t/ep93xx/u-boot.lds' is never used.

Please delete either of them.




Best Regards
Masahiro Yamada

  reply	other threads:[~2014-07-07 10:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 19:44 [U-Boot] [PATCH v6] arm: ep9315: Return back Cirrus Logic EDB9315A board support Sergey Kostanbev
2014-07-04 22:22 ` Albert ARIBAUD
2014-07-07 10:57   ` Masahiro Yamada [this message]
2014-07-25 16:27     ` sergey kostanbaev
2014-07-27 11:29       ` sergey kostanbaev
  -- strict thread matches above, loose matches on Subject: below --
2014-06-22 10:51 Sergey Kostanbev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140707195754.4481.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox