From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL
Date: Thu, 10 Jul 2014 13:30:38 +0200 [thread overview]
Message-ID: <201407101330.38683.marex@denx.de> (raw)
In-Reply-To: <20140710195219.CCC6.AA925319@jp.panasonic.com>
On Thursday, July 10, 2014 at 12:52:19 PM, Masahiro Yamada wrote:
> Hi Marek,
Hi!
[...]
> > Or just use put_unaligned() ?
>
> Oh, year! put_unaligned() would be better.
> Thanks!
>
> > > > > +
> > > > > + /* setup the pipeline command */
> > > > > + index_addr(cmd, 0x2000 | page_count);
> > > >
> > > > Magic value 0x2000 should be fixed here.
> > >
> > > Actually, this part is the same as that of the normal Denali driver
> > > by Chin Liang See
> > > http://patchwork.ozlabs.org/patch/357717/
> > >
> > > Moreover, it is the same as in Linux Kernel.
> > >
> > > I understand what you mean, but I guess we can excuse here.
> >
> > OK, I see. Is there any chance to fix this in Linux maybe eventually?
>
> OK.
> I will send a patch to linux-mtd ML
> to use "#define PIPELINE_ACCESS 2000"
Ack on both, thank you !
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-07-10 11:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 10:19 [U-Boot] [PATCH 0/6] Add support for Panasonic UniPhier SoCs/boards Masahiro Yamada
2014-07-04 10:19 ` [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL Masahiro Yamada
2014-07-04 14:34 ` Marek Vasut
2014-07-10 10:06 ` Masahiro Yamada
2014-07-10 10:10 ` Marek Vasut
2014-07-10 10:52 ` Masahiro Yamada
2014-07-10 11:30 ` Marek Vasut [this message]
2014-07-11 2:19 ` Masahiro Yamada
2014-07-04 10:19 ` [U-Boot] [PATCH 2/6] serial: add UniPhier serial driver Masahiro Yamada
2014-07-04 14:40 ` Marek Vasut
2014-07-10 10:06 ` Masahiro Yamada
2014-07-10 10:14 ` Marek Vasut
2014-07-10 11:31 ` Masahiro Yamada
2014-07-10 12:37 ` Marek Vasut
2014-07-11 5:37 ` Masahiro Yamada
2014-07-11 8:07 ` Marek Vasut
2014-07-04 10:19 ` [U-Boot] [PATCH 3/6] arm: uniphier: add UniPhier SoC suppurt code Masahiro Yamada
2014-08-20 9:31 ` Albert ARIBAUD
2014-08-21 11:27 ` Masahiro Yamada
2014-07-04 10:19 ` [U-Boot] [PATCH 4/6] arm: uniphier: add UniPhier config headers Masahiro Yamada
2014-07-04 10:19 ` [U-Boot] [PATCH 5/6] arm: uniphier: add board entries to boards.cfg Masahiro Yamada
2014-07-04 10:19 ` [U-Boot] [PATCH 6/6] git-mailrc: add me as the maintainer of UniPhier SoCs Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201407101330.38683.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox