From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 10 Jul 2014 13:30:38 +0200
Subject: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for
	SPL
In-Reply-To: <20140710195219.CCC6.AA925319@jp.panasonic.com>
References: <20140710190620.CCBE.AA925319@jp.panasonic.com>
	<201407101210.25186.marex@denx.de>
	<20140710195219.CCC6.AA925319@jp.panasonic.com>
Message-ID: <201407101330.38683.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday, July 10, 2014 at 12:52:19 PM, Masahiro Yamada wrote:
> Hi Marek,

Hi!

[...]

> > Or just use put_unaligned() ?
> 
> Oh, year!  put_unaligned() would be better.
> Thanks!
> 
> > > > > +
> > > > > +	/* setup the pipeline command */
> > > > > +	index_addr(cmd, 0x2000 | page_count);
> > > > 
> > > > Magic value 0x2000 should be fixed here.
> > > 
> > > Actually, this part is the same as that of the normal Denali driver
> > > by Chin Liang See
> > > http://patchwork.ozlabs.org/patch/357717/
> > > 
> > > Moreover, it is the same as in Linux Kernel.
> > > 
> > > I understand what you mean, but I guess we can excuse here.
> > 
> > OK, I see. Is there any chance to fix this in Linux maybe eventually?
> 
> OK.
> I will send a patch to linux-mtd ML
> to use  "#define PIPELINE_ACCESS    2000"

Ack on both, thank you !

Best regards,
Marek Vasut