[U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

Marek Vasut
2014-07-10T11:30:38Z

On Thursday, July 10, 2014 at 12:52:19 PM, Masahiro Yamada wrote:
> Hi Marek,

Hi!

[...]

> > Or just use put_unaligned() ?
>
> Oh, year! put_unaligned() would be better.
> Thanks!
>
> > > > > +
> > > > > + /* setup the pipeline command */
> > > > > + index_addr(cmd, 0x2000 | page_count);
> > > >
> > > > Magic value 0x2000 should be fixed here.
> > >
> > > Actually, this part is the same as that of the normal Denali driver
> > > by Chin Liang See
> > > http://patchwork.ozlabs.org/patch/357717/
> > >
> > > Moreover, it is the same as in Linux Kernel.
> > >
> > > I understand what you mean, but I guess we can excuse here.
> >
> > OK, I see. Is there any chance to fix this in Linux maybe eventually?
>
> OK.
> I will send a patch to linux-mtd ML
> to use "#define PIPELINE_ACCESS 2000"

Ack on both, thank you !

Best regards,
Marek Vasut