public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] socfpga: initialize designware ethernet
Date: Fri, 11 Jul 2014 11:49:49 +0200	[thread overview]
Message-ID: <201407111149.49461.marex@denx.de> (raw)
In-Reply-To: <20140711094556.GB4385@amd.pavel.ucw.cz>

On Friday, July 11, 2014 at 11:45:56 AM, Pavel Machek wrote:
[...]
> diff --git a/board/altera/socfpga/socfpga_cyclone5.c
> b/board/altera/socfpga/socfpga_cyclone5.c index a960eb6..2214ab7 100644
> --- a/board/altera/socfpga/socfpga_cyclone5.c
> +++ b/board/altera/socfpga/socfpga_cyclone5.c
> @@ -1,5 +1,6 @@
>  /*
>   *  Copyright (C) 2012 Altera Corporation <www.altera.com>
> + *  Copyright (C) 2014 Pavel Machek, pavel at denx.de

NAK ;-) Can you please keep the email address in this extremely relevant comment 
in the same format as above (in the <> chars) .

>   *
>   * SPDX-License-Identifier:	GPL-2.0+
>   */
> @@ -7,7 +8,7 @@
>  #include <common.h>
>  #include <asm/arch/reset_manager.h>
>  #include <asm/io.h>
> -
> +#include <miiphy.h>
>  #include <netdev.h>
> 
>  DECLARE_GLOBAL_DATA_PTR;
> @@ -67,5 +68,11 @@ int overwrite_console(void)
>  /* We know all the init functions have been run now */
>  int board_eth_init(bd_t *bis)
>  {
> +#if !defined(CONFIG_SOCFPGA_VIRTUAL_TARGET) && !defined(CONFIG_SPL_BUILD)
> +       /* initialize and register the emac */
> +	int rval = designware_initialize(CONFIG_EMAC_BASE,
> CONFIG_PHY_INTERFACE_MODE); +	return rval;
> +#else
>  	return 0;
> +#endif
>  }

Can this all not go into cpu_eth_init() and into arch/arm/... instead ?

[...]

Best regards,
Marek Vasut

  reply	other threads:[~2014-07-11  9:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  9:45 [U-Boot] [PATCH] socfpga: initialize designware ethernet Pavel Machek
2014-07-11  9:49 ` Marek Vasut [this message]
2014-07-11 10:40   ` Pavel Machek
2014-07-11 10:44     ` Marek Vasut
2014-07-13  8:06 ` [U-Boot] [PATCHv2] " Pavel Machek
2014-07-13 13:30   ` Marek Vasut
2014-07-14 12:14   ` [U-Boot] [PATCHv3] " Pavel Machek
2014-07-14 12:28     ` Marek Vasut
2014-07-14 12:38       ` Pavel Machek
2014-08-30 15:13     ` [U-Boot] [U-Boot, PATCHv3] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201407111149.49461.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox