From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix help text of ext2load and fatload.
Date: Mon, 14 Jul 2014 11:26:32 -0400 [thread overview]
Message-ID: <20140714152632.GD1847@bill-the-cat> (raw)
In-Reply-To: <20140709204007.GA28605@amd.pavel.ucw.cz>
On Wed, Jul 09, 2014 at 10:40:07PM +0200, Pavel Machek wrote:
>
> Fix help text of ext2load and fatload to match code in fs/fs.c
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
>
> diff --git a/common/cmd_ext2.c b/common/cmd_ext2.c
> index 5a4bcc1..2675ae8 100644
> --- a/common/cmd_ext2.c
> +++ b/common/cmd_ext2.c
> @@ -45,7 +45,7 @@ U_BOOT_CMD(
> U_BOOT_CMD(
> ext2load, 6, 0, do_ext2load,
> "load binary file from a Ext2 filesystem",
> - "<interface> <dev[:part]> [addr] [filename] [bytes]\n"
> + "<interface> [<dev[:part]> [addr [filename [bytes [pos]]]]]\n"
Wait, what? [] is optional, <> is mandatory. With the rest of the
related patches I see you fix a problem about assuming addr but we still
have to pass along a dev at least, yes?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140714/55183982/attachment.pgp>
next prev parent reply other threads:[~2014-07-14 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 20:40 [U-Boot] [PATCH] Fix help text of ext2load and fatload Pavel Machek
2014-07-09 21:05 ` Marek Vasut
2014-07-09 22:57 ` Pavel Machek
2014-07-14 15:26 ` Tom Rini [this message]
2014-07-15 21:37 ` Pavel Machek
2014-07-22 19:22 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714152632.GD1847@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox