From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/6] pwm, imx6: add support for pwm modul on imx6
Date: Wed, 16 Jul 2014 11:44:18 +0200 [thread overview]
Message-ID: <20140716094418.8D3EB380852@gemini.denx.de> (raw)
In-Reply-To: <53C64270.7050507@denx.de>
Dear Stefano & Heiko,
In message <53C64270.7050507@denx.de> you wrote:
>
> > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> > new file mode 100644
> > index 0000000..c70e150
> > --- /dev/null
> > +++ b/drivers/pwm/pwm-imx.c
> > @@ -0,0 +1,109 @@
> > +/*
> > + * (C) Copyright 2014
> > + * Heiko Schocher, DENX Software Engineering, hs at denx.de.
> > + *
> > + * Basic support for the pwm modul on imx6.
> > + *
> > + * Based on linux:drivers/pwm/pwm-imx.c
> > + * from
> > + * Sascha Hauer <s.hauer@pengutronix.de>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0+
Is this really GPL-2.0+ ? The Linux driver is definitely GPL-2.0
only!
> Nice ! Should we also add in the commit message that the code is
> directly taken from kernel driver ?
Not should - must!
Exact reference including commit ID is mandatory!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you're out of tree, you don't exist.
- David Woodhouse in <1304620350.2398.29.camel@i7.infradead.org>
next prev parent reply other threads:[~2014-07-16 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 8:51 [U-Boot] [PATCH v3 0/6] arm, imx6: add aristainetos board support Heiko Schocher
2014-07-16 8:51 ` [U-Boot] [PATCH v3 1/6] imx6: add gpr2 usb_otg_id iomux select control define Heiko Schocher
2014-07-16 8:51 ` [U-Boot] [PATCH v3 2/6] i.MX6: define struct pwm_regs and PWMCR_* defines Heiko Schocher
2014-07-16 8:51 ` [U-Boot] [PATCH v3 3/6] pwm, imx6: add support for pwm modul on imx6 Heiko Schocher
2014-07-16 9:14 ` Stefano Babic
2014-07-16 9:21 ` Heiko Schocher
2014-07-16 9:44 ` Wolfgang Denk [this message]
2014-07-16 8:51 ` [U-Boot] [PATCH v3 4/6] i.MX6: add enable_spi_clk() Heiko Schocher
2014-07-16 8:51 ` [U-Boot] [PATCH v3 5/6] spi: add config option to enable the WP pin function on st micron flashes Heiko Schocher
2014-07-16 8:51 ` [U-Boot] [PATCH v3 6/6] arm, imx6: add aristainetos board Heiko Schocher
2014-07-16 9:20 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716094418.8D3EB380852@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox