From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 16 Jul 2014 16:06:54 -0400 Subject: [U-Boot] [PATCH v1 4/7] board/ti/am335x: add support for beaglebone NOR Cape In-Reply-To: <1404500717-775-5-git-send-email-pekon@ti.com> References: <1404500717-775-1-git-send-email-pekon@ti.com> <1404500717-775-5-git-send-email-pekon@ti.com> Message-ID: <20140716200654.GO1847@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Jul 05, 2014 at 12:35:14AM +0530, Pekon Gupta wrote: > This patch updates pin-mux for beaglebone NOR cape [1] > This cape has 128Mbits(16MBytes), x16, CFI compatible NOR Flash device. > > On Beaglebone, GPMC chip-select-0 is shared by both NAND and NOR capes, > so only one of them can be enabled at a time from board profile configs. > > [1] http://elinux.org/Beagleboardtoys:BeagleBone_128Mb_16-Bit_NOR_Module [snip] > @@ -200,73 +200,46 @@ static struct module_pin_mux nand_pin_mux[] = { > {OFFSET(gpmc_be0n_cle), (MODE(0) | PULLDOWN_EN)}, /* BE_CLE */ > {-1}, > }; > -#endif > -#if defined(CONFIG_NOR) && !defined(CONFIG_NOR_BOOT) > +#elif defined(CONFIG_NOR) > static struct module_pin_mux bone_norcape_pin_mux[] = { > - {OFFSET(lcd_data0), MODE(1) | PULLUDEN | RXACTIVE}, /* NOR_A0 */ It _looks_ like this is jsut whitespace only. Since that doesn't match the rest of the file, please don't do that. [snip] > #endif > > #if defined(CONFIG_NOR_BOOT) > -static struct module_pin_mux norboot_pin_mux[] = { > - {OFFSET(lcd_data1), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data2), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data3), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data4), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data5), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data6), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data7), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data8), MODE(1) | PULLUDDIS}, > - {OFFSET(lcd_data9), MODE(1) | PULLUDDIS}, > - {-1}, > -}; > - > void enable_norboot_pin_mux(void) > { > - configure_module_pin_mux(norboot_pin_mux); > + configure_module_pin_mux(bone_norcape_pin_mux); Did you boot test this? The system requirements here are a bit strict and I don't know if we can just do what you're doing here... -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: