From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 17 Jul 2014 08:57:03 -0400 Subject: [U-Boot] [PATCH v1 7/7] board/ti/dra7xx: add support for parallel NAND In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EB0348A@DBDE04.ent.ti.com> References: <1404500717-775-1-git-send-email-pekon@ti.com> <1404500717-775-8-git-send-email-pekon@ti.com> <20140716202058.GR1847@bill-the-cat> <20980858CB6D3A4BAE95CA194937D5E73EB0348A@DBDE04.ent.ti.com> Message-ID: <20140717125703.GU1847@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jul 17, 2014 at 10:59:58AM +0000, Gupta, Pekon wrote: > >From: Tom Rini [mailto:tom.rini at gmail.com] On Behalf Of Rini, Tom > >>On Sat, Jul 05, 2014 at 12:35:17AM +0530, Pekon Gupta wrote: > > > >> This patch adds support for x16 NAND device (MT29F2G16AAD) connected to GPMC > >> chip-select present on DRA7xx EVM. > >> On this board, GPMC_WPN and NAND_BOOTn are controlled by DIP switch, > >> So following board settings are required for NAND device detection: > >> SW5.9 (GPMC_WPN) = LOW > >> SW5.1 (NAND_BOOTn) = HIGH > > > >First, again, I don't like moving towards NAND being the default assumed > >present storage and making QSPI harder to use. Second, I forgot about > >this earlier but for the record and per later emails, we should just use > >CONFIG_CMD_NAND rather than CONFIG_NAND. > > > All your feedbacks taken, except below one which is bit trivial .. > > Converting CONFIG_NAND to CONFIG_CMD_NAND need review because: > (1) CONFIG_NAND has spread to so many files, and is also part of > include/configs/ti_armv7_common.h > arch/arm/cpu/armv7/omap-common/mem.c > And many more places.. > > (2) CONFIG_CMD_NAND is not synonymous with other CONFIG_xx which > used for enabling complete subsystem like CONFIG_NOR, CONFIG_MMC. > > So, for now I'll continue using CONFIG_NAND, and may be later if > CONFIG_NAND needs to be deprecated, then it can come as separate > patch series. Hope that is fine? OK, I can live with that for now, thanks. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: