From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] scripts: add scripts/gnu_make to not hard-code make command
Date: Tue, 22 Jul 2014 12:54:47 +0900 [thread overview]
Message-ID: <20140722125447.EF1E.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <53C96548.5020408@myspectrum.nl>
Hi Jeroen,
On Fri, 18 Jul 2014 20:19:52 +0200
Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> > Instead, they should call the make command via this helper script
> > to make sure it is GNU Make.
>
> yup, or the name of the executable could be displayed, so
> it only needs to be checked once at startup (and error out
> if no GNU make is found at all).
Good idea!
MAKEALL and buildman generally invoke make for a lot of boards.
Searching it once at startup seems better.
> > +++ b/scripts/gnu_make
>
> nitpicking, most script use a dash instead of an underscore.
Renamed in v2.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-07-22 3:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 9:17 [U-Boot] [PATCH 0/3] Do not hard-code the command name 'make' in upper-level tools Masahiro Yamada
2014-07-17 9:18 ` [U-Boot] [PATCH 1/3] scripts: add scripts/gnu_make to not hard-code make command Masahiro Yamada
2014-07-18 18:19 ` Jeroen Hofstee
2014-07-22 3:54 ` Masahiro Yamada [this message]
2014-07-17 9:18 ` [U-Boot] [PATCH 2/3] MAKEALL: make sure to invoke GNU Make Masahiro Yamada
2014-07-18 18:29 ` Jeroen Hofstee
2014-07-19 4:41 ` Simon Glass
2014-07-17 9:18 ` [U-Boot] [PATCH 3/3] buildman: " Masahiro Yamada
2014-07-19 4:40 ` Simon Glass
2014-07-20 18:13 ` Jeroen Hofstee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722125447.EF1E.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox