From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/3] serial: ns16550: drop CONFIG_OMAP1610 from the special case
Date: Tue, 22 Jul 2014 15:22:38 -0400 [thread overview]
Message-ID: <20140722192238.GD1847@bill-the-cat> (raw)
In-Reply-To: <1405078144-27885-2-git-send-email-yamada.m@jp.panasonic.com>
On Fri, Jul 11, 2014 at 08:29:02PM +0900, Masahiro Yamada wrote:
> If CONFIG_OMAP1610 is defined, the code returning the fixed value (26)
> is enabled. But this case is covered by the following code.
>
> (CONFIG_SYS_NS16550_CLK + (gd->baudrate * (MODE_X_DIV / 2))) /
> (MODE_X_DIV * gd->baudrate)
> = (48000000 + (115200 * (16 / 2))) / (16 * 115200)
> = 48921600 / 1843200
> = 26
>
> The "#ifdef CONFIG_OMAP1610" was added by commit 6f21347d more than
> ten years ago. In those days, the divide-and-round was not used.
> I guess that is why this weird code was added here.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Tom Rini <trini@ti.com>
> Cc: Rishi Bhattacharya <rishi@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140722/690d155e/attachment.pgp>
next prev parent reply other threads:[~2014-07-22 19:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 11:29 [U-Boot] [PATCH 0/3] Collection of ns16550 UART driver refactoring Masahiro Yamada
2014-07-11 11:29 ` [U-Boot] [PATCH 1/3] serial: ns16550: drop CONFIG_OMAP1610 from the special case Masahiro Yamada
2014-07-11 11:52 ` Masahiro Yamada
2014-07-22 19:22 ` Tom Rini [this message]
2014-07-11 11:29 ` [U-Boot] [PATCH 2/3] serial: ns16550: use DIV_ROUND_CLOSEST macro to compute the divisor Masahiro Yamada
2014-07-22 19:22 ` [U-Boot] [U-Boot, " Tom Rini
2014-07-11 11:29 ` [U-Boot] [PATCH 3/3] serial: ns16550: use a const variable instead of macro Masahiro Yamada
2014-07-11 11:50 ` Marek Vasut
2014-07-22 19:22 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722192238.GD1847@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox