From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 22 Jul 2014 15:22:38 -0400 Subject: [U-Boot] [U-Boot, 1/3] serial: ns16550: drop CONFIG_OMAP1610 from the special case In-Reply-To: <1405078144-27885-2-git-send-email-yamada.m@jp.panasonic.com> References: <1405078144-27885-2-git-send-email-yamada.m@jp.panasonic.com> Message-ID: <20140722192238.GD1847@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jul 11, 2014 at 08:29:02PM +0900, Masahiro Yamada wrote: > If CONFIG_OMAP1610 is defined, the code returning the fixed value (26) > is enabled. But this case is covered by the following code. > > (CONFIG_SYS_NS16550_CLK + (gd->baudrate * (MODE_X_DIV / 2))) / > (MODE_X_DIV * gd->baudrate) > = (48000000 + (115200 * (16 / 2))) / (16 * 115200) > = 48921600 / 1843200 > = 26 > > The "#ifdef CONFIG_OMAP1610" was added by commit 6f21347d more than > ten years ago. In those days, the divide-and-round was not used. > I guess that is why this weird code was added here. > > Signed-off-by: Masahiro Yamada > Cc: Tom Rini > Cc: Rishi Bhattacharya Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: