From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f()
Date: Wed, 23 Jul 2014 09:31:14 -0400 [thread overview]
Message-ID: <20140723133114.GC1847@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2_F13M+O-o+vdSgYVvcerXvB7bgm2=Qh7ysnN7f4zBOQ@mail.gmail.com>
On Wed, Jul 23, 2014 at 06:16:52AM -0600, Simon Glass wrote:
> +Albert, Tom
>
> Hi Albert,
>
> On 11 July 2014 11:44, Jeroen Hofstee <dasuboot@myspectrum.nl> wrote:
> > Hello Simon,
> >
> >
> > On 11-07-14 06:23, Simon Glass wrote:
> >>
> >> At present arm defines CONFIG_SYS_GENERIC_GLOBAL_DATA, meaning that
> >> the global_data pointer is set up in board_init_f(). However it is
> >> actually set up before this, it just isn't zeroed.
> >>
> >> If we zero the global data before calling board_init_f() then we
> >> don't need to define CONFIG_SYS_GENERIC_GLOBAL_DATA.
> >>
> >> Make this change (on arm32 only) to simplify the init process. I
> >> don't have the ability to test aarch64 yet.
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> ---
> >>
> >> Changes in v3:
> >> - Fix assembler code comment in crt0.S to say GD, not BSS
> >> - Ensure that aarch64 stays as it was
> >> - Add newline after clr_gd label
> >> - Remove redundant mov r0, #0
>
> Are you happy with this patch? I would like to apply to to the dm
> repo, but would quite like to get an ack first.
Acked-by: Tom Rini <trini@ti.com>
But still want Albert to chime in too. He should be back now :)
>
> >>
> >> Changes in v2: None
> >>
> >> arch/arm/include/asm/config.h | 2 ++
> >> arch/arm/lib/crt0.S | 9 +++++++++
> >> 2 files changed, 11 insertions(+)
> >
> > Looks good to me. I picked up this one instead
> > of my memset version.
>
> >
> > Thanks, Jeroen
>
> Regards,
> Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140723/4a4cf86c/attachment.pgp>
next prev parent reply other threads:[~2014-07-23 13:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 4:23 [U-Boot] [PATCH v3 0/9] Add a pre-relocation malloc() implementation Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 1/9] Remove form-feeds from dlmalloc.c Simon Glass
2014-07-26 15:22 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f() Simon Glass
2014-07-11 17:44 ` Jeroen Hofstee
2014-07-23 12:16 ` Simon Glass
2014-07-23 13:31 ` Tom Rini [this message]
2014-07-28 12:17 ` Simon Glass
2014-08-09 21:26 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 3/9] sandbox: " Simon Glass
2014-07-26 15:22 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 4/9] Add a simple malloc() implementation for pre-relocation Simon Glass
2014-07-26 15:23 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 5/9] arm: Support pre-relocation malloc() Simon Glass
2014-07-23 12:19 ` Simon Glass
2014-08-09 21:25 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 6/9] exynos: Enable " Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 7/9] sandbox: Support " Simon Glass
2014-07-26 15:23 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 8/9] sandbox: config: Enable " Simon Glass
2014-07-26 15:24 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 9/9] sandbox: Always enable malloc debug Simon Glass
2014-07-26 15:24 ` Simon Glass
2014-07-14 22:28 ` [U-Boot] [PATCH v3 0/9] Add a pre-relocation malloc() implementation Tom Rini
2014-07-15 0:16 ` Simon Glass
2014-07-23 12:24 ` Simon Glass
2014-07-23 13:41 ` Tom Rini
2014-07-28 12:16 ` Simon Glass
2014-08-04 11:21 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723133114.GC1847@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox