From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 23 Jul 2014 09:31:14 -0400 Subject: [U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f() In-Reply-To: References: <1405052613-20987-1-git-send-email-sjg@chromium.org> <1405052613-20987-3-git-send-email-sjg@chromium.org> <53C0228C.2050007@myspectrum.nl> Message-ID: <20140723133114.GC1847@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jul 23, 2014 at 06:16:52AM -0600, Simon Glass wrote: > +Albert, Tom > > Hi Albert, > > On 11 July 2014 11:44, Jeroen Hofstee wrote: > > Hello Simon, > > > > > > On 11-07-14 06:23, Simon Glass wrote: > >> > >> At present arm defines CONFIG_SYS_GENERIC_GLOBAL_DATA, meaning that > >> the global_data pointer is set up in board_init_f(). However it is > >> actually set up before this, it just isn't zeroed. > >> > >> If we zero the global data before calling board_init_f() then we > >> don't need to define CONFIG_SYS_GENERIC_GLOBAL_DATA. > >> > >> Make this change (on arm32 only) to simplify the init process. I > >> don't have the ability to test aarch64 yet. > >> > >> Signed-off-by: Simon Glass > >> --- > >> > >> Changes in v3: > >> - Fix assembler code comment in crt0.S to say GD, not BSS > >> - Ensure that aarch64 stays as it was > >> - Add newline after clr_gd label > >> - Remove redundant mov r0, #0 > > Are you happy with this patch? I would like to apply to to the dm > repo, but would quite like to get an ack first. Acked-by: Tom Rini But still want Albert to chime in too. He should be back now :) > > >> > >> Changes in v2: None > >> > >> arch/arm/include/asm/config.h | 2 ++ > >> arch/arm/lib/crt0.S | 9 +++++++++ > >> 2 files changed, 11 insertions(+) > > > > Looks good to me. I picked up this one instead > > of my memset version. > > > > > Thanks, Jeroen > > Regards, > Simon > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: