[U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

Ian Campbell
2014-07-07T15:10:42Z

On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote:
> AFAIK we will never define both EMAC and GMAC for the same board,

If we are sure of this (and I suspect this is the case, since IIRC they
share some pins) then I agree with your suggestion.

> so IMHO a better fix would be to change this line:
>
> rc = sunxi_emac_initialize(bis);
>
> to:
>
> int rc = sunxi_emac_initialize(bis);
>
> And the same for gmac.
>
> Regards,
>
> Hans
>
>
>
>
>