[U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

Tom Rini
2014-07-07T16:47:02Z

On Mon, Jul 07, 2014 at 04:10:42PM +0100, Ian Campbell wrote:
> On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote:
> > AFAIK we will never define both EMAC and GMAC for the same board,
>
> If we are sure of this (and I suspect this is the case, since IIRC they
> share some pins) then I agree with your suggestion.
>
> > so IMHO a better fix would be to change this line:
> >
> > rc = sunxi_emac_initialize(bis);
> >
> > to:
> >
> > int rc = sunxi_emac_initialize(bis);

That's not how we like things to look however when we can help it. Just
toss a __maybe_unused in front of the declaration (and make sure we have
<linux/compiler.h> included.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140707/5ddad13c/attachment.pgp>