[U-Boot] [PATCH v2 3/5] sunxi: Add axp209 pmic support

Ian Campbell
2014-07-17T19:14:19Z

On Thu, 2014-07-17 at 12:37 +0200, Hans de Goede wrote:
> Hi,
>
> On 07/16/2014 11:48 PM, Ian Campbell wrote:
> > On Fri, 2014-06-13 at 22:55 +0200, Hans de Goede wrote:
> >> From: Henrik Nordstrom <henrik@henriknordstrom.net>
> >>
> >> Add support for the x-powers axp209 pmic which is found on most A10, A13 and
> >> A20 boards.
> >>
> >> And enable AXP209 support for the Cubietruck and Cubieboard boards.
> >
> > Something about this breaks booting on my Cubietruck in FEL mode. I get:
> >
> > U-Boot SPL 2014.07-rc4-00122-g624959a (Jul 16 2014 - 22:34:59)
> > Error, wrong i2c adapter 0 max 0 possible
> > Error, wrong i2c adapter 0 max 0 possible
> >
> > And then nothing.
>
> If you look at the patch adding support for the i2c controller I needed
> to make some changes to the link script, I probably forgot to make the
> same changes to the fel link script...

That was indeed it. With your ACK I'd like to fold in this change:

- - a/arch/arm/cpu/armv7/sunxi/u-boot-spl-fel.lds
+ + b/arch/arm/cpu/armv7/sunxi/u-boot-spl-fel.lds
@@ -27,6 +27,11 @@ SECTIONS
}

. = ALIGN(4);
+ .u_boot_list : {
+ KEEP(*(SORT(.u_boot_list*)));
+ }
+
+ . = ALIGN(4);
. = .;

. = ALIGN(4);

> >> While changing the boards.cfg lines for the Cubietruck, add Ian and me as board
> >> maintainers for the Cubietruck.
> >
> > You actually factored that bit out in v2...
>
> True, feel free to amend the commit msg, or let me know if you want a v3.

I'll amend while I'm there.

> And thanks for looking into merging this into sunxi -next. I was planning to
> drop you a mail about coordinating getting this added vs getting your ahci
> patches added. I assume you ahci patches are good to go too, or ... ?

I've picked up the non-AHCI bits of that series now but not the common
bits which I'm assuming Albert will pick up when he gets back, the
actual driver then depends on those. So I've picked up and intend to
include in the first PR:
[U-Boot,3/6] sunxi: add Cubieboard2 support
[U-Boot,4/6] sunxi: add gpio driver
[U-Boot,5/6] sunxi: use setbits_le32 to enable the DMA clock

These I am expecting to come via Albert (or for him to ask me to merge):
[U-Boot,1/6] AHCI: Increase link timeout to 200ms
[U-Boot,2/6] board_r: run scsi init() on ARM too

and then the last one
[U-Boot,6/6] ahci: provide sunxi SATA driver using AHCI platform framework
either Albert can pick up or it can come in a subsequent PR.

Other than those there are Roman's USB patch which are still under review.

> Next I want to start adding support for more boards. For starters I would
> like to add all boards which also have a dts file in the upstream kernel.
> Ideally I would start working on that once you're done with adding this
> series + your ahci patches so that we don't get in each others way. Can you
> send me a mail when you're done (for a while at least) then I'll try to
> get a set of patches for this to the list based on top of your latest work.

Sure, I'll drop you a line.

> Except for sun4i-a10-hackberry.dts and sun4i-a10-inet97fv2.dts I've hardware
> to test on for all sun4i, sun5i and sun7i models which have a dts file, not
> sure what to do with the 2 I cannot test.

Either leave them out or approach the person who wrote the dts (who
presumably has one, or isthat asking too much) to test?

Ian