From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 24 Jul 2014 09:50:29 -0400 Subject: [U-Boot] [PATCH] Makefile: use u-boot.map for binary_size_check In-Reply-To: <20140724083114.099343822C9@gemini.denx.de> References: <1406179627-9496-1-git-send-email-judge.packham@gmail.com> <20140724083114.099343822C9@gemini.denx.de> Message-ID: <20140724135029.GH1847@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jul 24, 2014 at 10:31:14AM +0200, Wolfgang Denk wrote: > Dear Chris Packham, > > In message <1406179627-9496-1-git-send-email-judge.packham@gmail.com> you wrote: > > u-boot.map is generated automatically by the compiler and more > > importantly can handle addresses >4GB. > ... > > > I think it should be possible to change binary_size_check to use > > > u-boot.map instead of System.map but would that be OK for all > > > architectures? > ... > > Something like this works for me but maybe there is a way to get nm to handle > > addresses >4GB. > ... > > + map_size=$(shell cat u-boot.map | \ > > awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \ > > + | sed 's/0X//g' \ > > > Do we _really_ need all of this? > > This looks very much like creaping featurism to me... So it's a safetey check. The various linker script clean-ups we've been doing have introduced a problem from time to time and binary_check_size gives a sanity check. This just fixes a corner case in the test. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: