From mboxrd@z Thu Jan 1 00:00:00 1970 From: Siarhei Siamashka Date: Fri, 25 Jul 2014 07:36:54 +0300 Subject: [U-Boot] [PATCH 12/14] sunxi: dram: Drop DDR2 support and assume only single rank DDR3 memory In-Reply-To: <1405972272.4100.24.camel@hastur.hellion.org.uk> References: <1405700585-13546-1-git-send-email-siarhei.siamashka@gmail.com> <1405700585-13546-13-git-send-email-siarhei.siamashka@gmail.com> <1405972272.4100.24.camel@hastur.hellion.org.uk> Message-ID: <20140725073654.4e0cb7f8@i7> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 21 Jul 2014 20:51:12 +0100 Ian Campbell wrote: > On Fri, 2014-07-18 at 19:23 +0300, Siarhei Siamashka wrote: > > All the known Allwinner A10/A13/A20 devices are using just single rank > > DDR3 memory. So don't pretend that we support DDR2 or more than one > > rank, because nobody could ever test these configurations for real and > > they are likely broken. Support for these features can be added back > > in the case if such hardware actually exists. > > > + if (para->type != DRAM_MEMORY_TYPE_DDR3 || para->rank_num != 1) > > + return 0; > > Can we not go further and remove these fields from the para struct too? Right now the DRAM patchset keeps backwards compatibility with the old 'dram_para' settings. This is intended to ensure that it is a drop-in replacement for the old code and make the transition easier. The fields can be removed at any time later as a cosmetic fix. -- Best regards, Siarhei Siamashka