* [U-Boot] [PATCH] usb: ehci: rmobile: Add support R8A7794
@ 2014-07-24 5:52 Nobuhiro Iwamatsu
2014-07-24 21:38 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-07-24 5:52 UTC (permalink / raw)
To: u-boot
R8A7794 has same IP of USB controller as R8A7790 and R8A7791.
This addes support for R8A7794.
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
drivers/usb/host/ehci-rmobile.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/ehci-rmobile.c b/drivers/usb/host/ehci-rmobile.c
index 049e4c4..29b4a93 100644
--- a/drivers/usb/host/ehci-rmobile.c
+++ b/drivers/usb/host/ehci-rmobile.c
@@ -29,6 +29,12 @@ static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
0xEE0C0000, /* USB1 */
0xEE000000 /* USB3 (USB3.0 Host)*/
};
+#elif defined(CONFIG_R8A7794)
+static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
+ 0xEE080000, /* USB0 (EHCI) */
+ 0xEE0C0000, /* USB1 */
+ /* R8A7794 does not have USB 3.0. */
+};
#else
#error rmobile EHCI USB driver not supported on this platform
#endif
--
2.0.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] usb: ehci: rmobile: Add support R8A7794
2014-07-24 5:52 [U-Boot] [PATCH] usb: ehci: rmobile: Add support R8A7794 Nobuhiro Iwamatsu
@ 2014-07-24 21:38 ` Marek Vasut
2014-07-28 6:17 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2014-07-24 21:38 UTC (permalink / raw)
To: u-boot
On Thursday, July 24, 2014 at 07:52:07 AM, Nobuhiro Iwamatsu wrote:
> R8A7794 has same IP of USB controller as R8A7790 and R8A7791.
> This addes support for R8A7794.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> drivers/usb/host/ehci-rmobile.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-rmobile.c
> b/drivers/usb/host/ehci-rmobile.c index 049e4c4..29b4a93 100644
> --- a/drivers/usb/host/ehci-rmobile.c
> +++ b/drivers/usb/host/ehci-rmobile.c
> @@ -29,6 +29,12 @@ static u32
> usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE0C0000, /* USB1
> */
> 0xEE000000 /* USB3 (USB3.0 Host)*/
Just a side-note ... Will this one USB3 controller above really work with the
EHCI driver ? I know there is a compat mode for xHCI, but I'm not quite sure
it's this easy to make it operational.
> };
> +#elif defined(CONFIG_R8A7794)
> +static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
> + 0xEE080000, /* USB0 (EHCI) */
> + 0xEE0C0000, /* USB1 */
> + /* R8A7794 does not have USB 3.0. */
> +};
> #else
> #error rmobile EHCI USB driver not supported on this platform
> #endif
Applied, thanks.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] usb: ehci: rmobile: Add support R8A7794
2014-07-24 21:38 ` Marek Vasut
@ 2014-07-28 6:17 ` Nobuhiro Iwamatsu
2014-07-28 6:46 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-07-28 6:17 UTC (permalink / raw)
To: u-boot
Hi, Marek.
Thanks for your review.
2014-07-25 6:38 GMT+09:00 Marek Vasut <marex@denx.de>:
> On Thursday, July 24, 2014 at 07:52:07 AM, Nobuhiro Iwamatsu wrote:
>> R8A7794 has same IP of USB controller as R8A7790 and R8A7791.
>> This addes support for R8A7794.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> ---
>> drivers/usb/host/ehci-rmobile.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/usb/host/ehci-rmobile.c
>> b/drivers/usb/host/ehci-rmobile.c index 049e4c4..29b4a93 100644
>> --- a/drivers/usb/host/ehci-rmobile.c
>> +++ b/drivers/usb/host/ehci-rmobile.c
>> @@ -29,6 +29,12 @@ static u32
>> usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE0C0000, /* USB1
>> */
>> 0xEE000000 /* USB3 (USB3.0 Host)*/
>
> Just a side-note ... Will this one USB3 controller above really work with the
> EHCI driver ? I know there is a compat mode for xHCI, but I'm not quite sure
> it's this easy to make it operational.
You are right.
ehci-rmobile.c cannot handle USB 3.0.
I send a patch for corrections immediately.
>
>> };
>> +#elif defined(CONFIG_R8A7794)
>> +static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
>> + 0xEE080000, /* USB0 (EHCI) */
>> + 0xEE0C0000, /* USB1 */
>> + /* R8A7794 does not have USB 3.0. */
>> +};
>> #else
>> #error rmobile EHCI USB driver not supported on this platform
>> #endif
>
> Applied, thanks.
Thank you.
>
> Best regards,
> Marek Vasut
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] usb: ehci: rmobile: Add support R8A7794
2014-07-28 6:17 ` Nobuhiro Iwamatsu
@ 2014-07-28 6:46 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2014-07-28 6:46 UTC (permalink / raw)
To: u-boot
On Monday, July 28, 2014 at 08:17:29 AM, Nobuhiro Iwamatsu wrote:
> Hi, Marek.
>
> Thanks for your review.
>
> 2014-07-25 6:38 GMT+09:00 Marek Vasut <marex@denx.de>:
> > On Thursday, July 24, 2014 at 07:52:07 AM, Nobuhiro Iwamatsu wrote:
> >> R8A7794 has same IP of USB controller as R8A7790 and R8A7791.
> >> This addes support for R8A7794.
> >>
> >> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >> ---
> >>
> >> drivers/usb/host/ehci-rmobile.c | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/drivers/usb/host/ehci-rmobile.c
> >> b/drivers/usb/host/ehci-rmobile.c index 049e4c4..29b4a93 100644
> >> --- a/drivers/usb/host/ehci-rmobile.c
> >> +++ b/drivers/usb/host/ehci-rmobile.c
> >> @@ -29,6 +29,12 @@ static u32
> >> usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE0C0000, /*
> >> USB1 */
> >>
> >> 0xEE000000 /* USB3 (USB3.0 Host)*/
> >
> > Just a side-note ... Will this one USB3 controller above really work with
> > the EHCI driver ? I know there is a compat mode for xHCI, but I'm not
> > quite sure it's this easy to make it operational.
>
> You are right.
> ehci-rmobile.c cannot handle USB 3.0.
> I send a patch for corrections immediately.
Cool, thanks :) I'll pick it later today.
[...]
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-28 6:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-24 5:52 [U-Boot] [PATCH] usb: ehci: rmobile: Add support R8A7794 Nobuhiro Iwamatsu
2014-07-24 21:38 ` Marek Vasut
2014-07-28 6:17 ` Nobuhiro Iwamatsu
2014-07-28 6:46 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox