From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/12] mtd: nand: s3c: Fix data type width in debug()
Date: Tue, 29 Jul 2014 02:09:24 +0200 [thread overview]
Message-ID: <201407290209.24617.marex@denx.de> (raw)
In-Reply-To: <1406590557.29414.208.camel@snotra.buserror.net>
On Tuesday, July 29, 2014 at 01:35:57 AM, Scott Wood wrote:
> On Tue, 2014-07-22 at 02:34 +0200, Marek Vasut wrote:
> > Printing u32 with %02x is just a bad idea, fix it.
>
> Why is it "just a bad idea" if the values aren't expected to exceed
> 0xff?
NAND_CMD_DEPLETE1 is 0x100 for example. I doubt anyone will use AND with this
controller, but I'd be much happier to see the print properly matching the
variable we're printing.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-07-29 0:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 0:34 [U-Boot] [PATCH 01/12] video: Add S3C24xx framebuffer support Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 02/12] arm: s3c24xx: Fix incorrect CONFIG_SYS_S3C2410_NAND_HWECC name Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 03/12] mtd: nand: s3c: Fix data type width in debug() Marek Vasut
2014-07-28 23:35 ` Scott Wood
2014-07-29 0:09 ` Marek Vasut [this message]
2014-07-29 0:12 ` Scott Wood
2014-07-29 1:11 ` Marek Vasut
2014-07-29 1:22 ` Scott Wood
2014-07-29 4:21 ` Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 04/12] mtd: nand: s3c: Unify the register definition and naming Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 05/12] mtd: nand: s3c: Add S3C2440 specifics Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 06/12] mtd: nand: s3c: Add S3C2440 buffer reading Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 07/12] mtd: nand: s3c: Add missing correction and select_chip functions Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 08/12] i2c: s3c: Implant support for S3C2440 Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 09/12] gpio: s3c: Fix the GPIO driver Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 10/12] arm: s3c: Unify the S3C24xx SDI structure Marek Vasut
2014-07-22 0:34 ` [U-Boot] [PATCH 11/12] mmc: s3c: Add SD driver Marek Vasut
2014-08-01 16:25 ` Pantelis Antoniou
2014-08-01 16:26 ` Pantelis Antoniou
2014-07-22 0:34 ` [U-Boot] [PATCH 12/12] net: smc911x: Keep MAC programmed Marek Vasut
2014-07-22 20:43 ` Joe Hershberger
2014-07-22 9:25 ` [U-Boot] [PATCH 01/12] video: Add S3C24xx framebuffer support Wolfgang Denk
2014-07-23 3:00 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201407290209.24617.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox