[U-Boot] [PATCH 03/18] sf: fix sf probe

Marek Vasut
2014-08-03T13:46:38Z

On Sunday, August 03, 2014 at 09:34:33 AM, Nikita Kiryanov wrote:
> MXC SPI driver has a feature whereas a GPIO line can be used as a CS
> signal. This is set up by joining the CS and GPIO values into a single
> value using (cs | gpio << 8), and passing it off as a CS value. This
> breaks the sf probe command, because it is no longer possible to invoke it
> as sf probe <cs>. Instead, the user must use sf probe <cs | gpio << 8>.
>
> Fix this by introducing a new board function: board_spi_cs_gpio().
> When called, board_spi_cs_gpio() will return the gpio number for the
> cs value it is given.
>
> Cc: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> Cc: Eric Nelson <eric.nelson@boundarydevices.com>
> Cc: Eric Benard <eric@eukrea.com>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>

Just curious, but is this fixing generic SF code or MXC SPI driver ? I'd think
the later, but it's not obvious from neither the description nor the subject. I
don't quite understand the problem that you're trying to fix either, what
happened, did the user command interface change ?

[...]
Best regards,
Marek Vasut