[U-Boot] [PATCH 18/18] arm: mx6: cm_fx6: add sata support

Igor Grinberg
2014-08-04T10:47:38Z

On 08/04/14 11:27, Marek Vasut wrote:
> On Monday, August 04, 2014 at 09:23:12 AM, Igor Grinberg wrote:
>> Hi Marek,
>>
>> On 08/03/14 17:10, Marek Vasut wrote:
>>> On Sunday, August 03, 2014 at 09:34:48 AM, Nikita Kiryanov wrote:
>>>> Add support for SATA.
>>>>
>>>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>>> Cc: Stefano Babic <sbabic@denx.de>
>>>> Cc: Tom Rini <trini@ti.com>
>>>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>>>
>>> I'd just squash all the cf_mx6 patches into the "add cf_mx6 board" patch.
>>
>> Well, I tend to disagree on this.
>> I find extremely hard to review the "long long squashed into one patch"
>> patches. It is much easier to review small, functionality oriented,
>> patches.
>
> You do have a valid point when it comes to review, all right. There's no point
> in keeping them separate when they're applied though. Tough decisions this is.

When it comes to keeping them separate when applied, I'd disagree also...
Keeping the changes small and functionality oriented helps:
a) bisect-ability and blaming/reverting granularity
b) gives an opportunity to better explain the change in the commit message
c) easier fixing of merge conflicts (if any)
d) learning curve for new developers in the log (as to how to add features/fix bugs)
e) a bit more burden on maintainers ;-)

--
Regards,
Igor.