[U-Boot] [PATCH 01/18] spl: improve spi configuration

Nikita Kiryanov
2014-08-05T13:28:04Z

On 03/08/14 16:44, Marek Vasut wrote:
> On Sunday, August 03, 2014 at 09:34:31 AM, Nikita Kiryanov wrote:
>> Currently we can define CONFIG_SPL_SPI_<any parameter except SPI MODE>.
>> Define CONFIG_SPL_SPI_MODE option, and provide a default value for
>> backwards compatibility.
>> Default values are also provided for the rest of the spi_flash_probe
>> parameters (like we do in cmd_sf), to help with config file brevity.
>>
>> Cc: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
>> Cc: Tom Rini <trini@ti.com>
>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>
> You might actually be even more bold and check if you cannot fall back to the
> CONFIG_DEFAULT_SPI_MODE etc. What do you think ?

Not a fan of the idea. It will:
- Complicate the #ifdefs
- Complicate the relationship between CONFIG_DEFAULT_SPI_* and
CONFIG_SPL_SPI_* #defines
- Not get much use: most boards do not #define CONFIG_DEFAULT_SPI_*
values in the config files, and of the ones that do, only two
(dra7xx_evm and cm_fx6) use SPI in SPL.
>
> Best regards,
> Marek Vasut
>