From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/18] arm: mx6: add support for Compulab cm-fx6 CoM
Date: Mon, 4 Aug 2014 17:12:27 +0200 [thread overview]
Message-ID: <201408041712.27425.marex@denx.de> (raw)
In-Reply-To: <53DF9B7F.8070301@compulab.co.il>
On Monday, August 04, 2014 at 04:41:03 PM, Nikita Kiryanov wrote:
> On 03/08/14 17:09, Marek Vasut wrote:
> > On Sunday, August 03, 2014 at 09:34:42 AM, Nikita Kiryanov wrote:
> >> Add initial support for Compulab CM-FX6 CoM.
> >> Support includes MMC, SPI flash, and SPL with dynamic DRAM detection.
> >>
> >> Cc: Igor Grinberg <grinberg@compulab.co.il>
> >> Cc: Stefano Babic <sbabic@denx.de>
> >> Cc: Tom Rini <trini@ti.com>
> >> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
> >> ---
> >>
> >> arch/arm/cpu/armv7/mx6/ddr.c | 1 -
> >> board/compulab/cm_fx6/Makefile | 12 ++
> >> board/compulab/cm_fx6/cm_fx6.c | 108 ++++++++++
> >> board/compulab/cm_fx6/common.c | 83 ++++++++
> >> board/compulab/cm_fx6/common.h | 36 ++++
> >> board/compulab/cm_fx6/imximage.cfg | 8 +
> >> board/compulab/cm_fx6/spl.c | 400
> >>
> >> +++++++++++++++++++++++++++++++++++++ boards.cfg
> >> |
> >>
> >> 2 +
> >>
> >> include/configs/cm_fx6.h | 227 +++++++++++++++++++++
> >> 9 files changed, 876 insertions(+), 1 deletion(-)
> >> create mode 100644 board/compulab/cm_fx6/Makefile
> >> create mode 100644 board/compulab/cm_fx6/cm_fx6.c
> >> create mode 100644 board/compulab/cm_fx6/common.c
> >> create mode 100644 board/compulab/cm_fx6/common.h
> >> create mode 100644 board/compulab/cm_fx6/imximage.cfg
> >> create mode 100644 board/compulab/cm_fx6/spl.c
> >> create mode 100644 include/configs/cm_fx6.h
> >>
> >> diff --git a/arch/arm/cpu/armv7/mx6/ddr.c b/arch/arm/cpu/armv7/mx6/ddr.c
> >> index d3891dc..219263a 100644
> >> --- a/arch/arm/cpu/armv7/mx6/ddr.c
> >> +++ b/arch/arm/cpu/armv7/mx6/ddr.c
> >> @@ -4,7 +4,6 @@
> >>
> >> *
> >> * SPDX-License-Identifier: GPL-2.0+
> >> */
> >>
> >> -
> >>
> >> #include <common.h>
> >> #include <linux/types.h>
> >> #include <asm/arch/mx6-ddr.h>
> >
> > Drop this piece ;-)
>
> Yep...
>
> > [...]
> >
> >> +++ b/board/compulab/cm_fx6/cm_fx6.c
> >
> > [...]
> >
> >> +static ulong bank1_size;
> >> +static ulong bank2_size;
> >> +
> >> +#define MMDC1_MDCTL 0x21B0000
> >> +static int probe_mmdc_config(void)
> >> +{
> >> + u32 val = readl(0x21B0000);
> >> + switch (val) {
> >> + case 0x83180000: /* DDR_16BIT_256MB */
> >> + gd->ram_size = 0x10000000;
> >> + bank1_size = 0x10000000;
> >> + bank2_size = 0;
> >> + break;
> >> + case 0x83190000: /* DDR_32BIT_512MB */
> >> + gd->ram_size = 0x20000000;
> >> + bank1_size = 0x20000000;
> >> + bank2_size = 0;
> >> + break;
> >
> > imx_ddr_size() won't cut it here ?
>
> It doesn't handle 4GB correctly (returns 0). I suppose
> I can make a patch which caps the return value of
> imx_ddr_size() for MX6 socs to 3840MB.
> What do you think?
That you should check the U-Boot ML, since that's what I did yesterday ;-) But
still, this is rather sad practice -- instead of fixing a bug in code which you
do know about, you implement such a workaround :-(
next prev parent reply other threads:[~2014-08-04 15:12 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-03 7:34 [U-Boot] [PATCH 00/18] Introduce cm-fx6 board Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 01/18] spl: improve spi configuration Nikita Kiryanov
2014-08-03 13:44 ` Marek Vasut
2014-08-05 13:28 ` Nikita Kiryanov
2014-08-05 14:11 ` Marek Vasut
2014-08-06 10:53 ` Nikita Kiryanov
2014-08-06 11:32 ` Marek Vasut
2014-08-03 7:34 ` [U-Boot] [PATCH 02/18] mx6: add clock enabling functions Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 03/18] sf: fix sf probe Nikita Kiryanov
2014-08-03 13:46 ` Marek Vasut
2014-08-04 12:48 ` Nikita Kiryanov
2014-08-04 13:10 ` Marek Vasut
2014-08-04 13:45 ` Nikita Kiryanov
2014-08-04 13:51 ` Marek Vasut
2014-08-04 14:11 ` Nikita Kiryanov
2014-08-04 14:20 ` Marek Vasut
2014-08-04 14:02 ` Tom Rini
2014-08-04 14:09 ` Marek Vasut
2014-08-04 14:19 ` Nikita Kiryanov
2014-08-04 14:58 ` Tom Rini
2014-08-03 7:34 ` [U-Boot] [PATCH 04/18] mtd: spi: add support for M25PE16 and M25PX16 Nikita Kiryanov
2014-08-03 13:47 ` Marek Vasut
2014-08-03 7:34 ` [U-Boot] [PATCH 05/18] compulab: eeprom: add support for defining eeprom i2c bus Nikita Kiryanov
2014-08-03 13:48 ` Marek Vasut
2014-08-04 12:49 ` Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 06/18] sata: dwc_ahsata: implement sata_port_status Nikita Kiryanov
2014-08-03 13:49 ` Marek Vasut
2014-08-04 12:49 ` Nikita Kiryanov
2014-08-04 13:10 ` Marek Vasut
2014-08-03 7:34 ` [U-Boot] [PATCH 07/18] i2c: imx: add macros to setup pads for multiple SoC types Nikita Kiryanov
2014-08-04 4:28 ` Tim Harvey
2014-08-03 7:34 ` [U-Boot] [PATCH 08/18] arm: mx6: ddr: cleanup Nikita Kiryanov
2014-08-04 5:26 ` Tim Harvey
2014-08-03 7:34 ` [U-Boot] [PATCH 09/18] arm: mx6: ddr: do not write into reserved bit Nikita Kiryanov
2014-08-04 5:43 ` Tim Harvey
2014-08-04 12:49 ` Nikita Kiryanov
2014-08-06 8:18 ` Tim Harvey
2014-08-06 8:31 ` Stefano Babic
2014-08-03 7:34 ` [U-Boot] [PATCH 10/18] arm: mx6: ddr: configure MMDC for slow_pd Nikita Kiryanov
2014-08-04 5:42 ` Tim Harvey
2014-08-04 12:49 ` Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 11/18] arm: mx6: ddr: fix cs0_end calculation Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 12/18] arm: mx6: add support for Compulab cm-fx6 CoM Nikita Kiryanov
2014-08-03 14:09 ` Marek Vasut
2014-08-04 14:41 ` Nikita Kiryanov
2014-08-04 15:12 ` Marek Vasut [this message]
2014-08-05 7:36 ` Nikita Kiryanov
2014-08-05 7:58 ` Marek Vasut
2014-08-04 4:45 ` Tim Harvey
2014-08-04 13:36 ` Nikita Kiryanov
2014-08-06 17:29 ` Nikita Kiryanov
2014-08-08 7:19 ` Tim Harvey
2014-08-10 16:20 ` Nikita Kiryanov
2014-08-04 6:02 ` Tim Harvey
2014-08-04 14:24 ` Nikita Kiryanov
2014-08-07 11:27 ` Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 13/18] arm: mx6: cm_fx6: add nand support Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 14/18] arm: mx6: cm_fx6: add ethernet support Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 15/18] arm: mx6: cm_fx6: add usb support Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 16/18] arm: mx6: cm_fx6: add i2c support Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 17/18] arm: mx6: cm_fx6: use eeprom Nikita Kiryanov
2014-08-03 7:34 ` [U-Boot] [PATCH 18/18] arm: mx6: cm_fx6: add sata support Nikita Kiryanov
2014-08-03 14:10 ` Marek Vasut
2014-08-04 7:23 ` Igor Grinberg
2014-08-04 8:27 ` Marek Vasut
2014-08-04 10:47 ` Igor Grinberg
2014-08-04 10:53 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201408041712.27425.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox