From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 5 Aug 2014 09:58:10 +0200 Subject: [U-Boot] [PATCH 12/18] arm: mx6: add support for Compulab cm-fx6 CoM In-Reply-To: <53E0897B.4050204@compulab.co.il> References: <1407051288-17324-1-git-send-email-nikita@compulab.co.il> <201408041712.27425.marex@denx.de> <53E0897B.4050204@compulab.co.il> Message-ID: <201408050958.11101.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, August 05, 2014 at 09:36:27 AM, Nikita Kiryanov wrote: [...] > >>> imx_ddr_size() won't cut it here ? > >> > >> It doesn't handle 4GB correctly (returns 0). I suppose > >> I can make a patch which caps the return value of > >> imx_ddr_size() for MX6 socs to 3840MB. > >> What do you think? > > > > That you should check the U-Boot ML, since that's what I did yesterday > > ;-) But still, this is rather sad practice -- instead of fixing a bug in > > code which you do know about, you implement such a workaround :-( > > Actually, I only learned of this bug yesterday after you asked about > imx_ddr_size(). Glad to hear you already fixed it; I'll look at it for > the v2. I did the capping, yep. HTH :) Best regards, Marek Vasut