From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 16/20] patman: buildman: Correct spelling of 'colour'
Date: Mon, 11 Aug 2014 16:34:36 -0400 [thread overview]
Message-ID: <20140811203436.GU19374@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ0oatKdWyOUik=aDoh_RLKRiWsvmqJYnykw+Omfagi3Jw@mail.gmail.com>
On Sat, Aug 09, 2014 at 04:34:47PM -0600, Simon Glass wrote:
> Hi Fabio,
>
> On 9 August 2014 16:29, Fabio Estevam <festevam@gmail.com> wrote:
> > On Sat, Aug 9, 2014 at 7:17 PM, Simon Glass <sjg@chromium.org> wrote:
> >> Hi,
> >>
> >> On 9 August 2014 16:01, Fabio Estevam <festevam@gmail.com> wrote:
> >>> Hi Simon,
> >>>
> >>> On Sat, Aug 9, 2014 at 6:33 PM, Simon Glass <sjg@chromium.org> wrote:
> >>>> This code came from another project. Correct the spelling now that it is
> >>>> in U-Boot.
> >>>
> >>> ....
> >>>
> >>>> - col: terminal.Color() object
> >>>> + col: terminal.Colour() object
> >>>
> >>> I thought that both forms were correct and that "color" is the
> >>> American way and "colour" the British one.
> >>
> >> Yes, but U-Boot doesn't use American English as I understand it, so
> >
> > I think it just depends on the code's author preference as both
> > formats are valid.
> >
> > Doing a quick grep in U-boot source:
> >
> > $ git grep color | wc -l
> > 646
> > $ git grep colour | wc -l
> > 43
>
> Yes that may well be true :-)
... so lets drop this patch, thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140811/53371119/attachment.pgp>
next prev parent reply other threads:[~2014-08-11 20:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 21:32 [U-Boot] [PATCH v6 0/20] Add some missing buildman features and deprecate MAKEALL Simon Glass
2014-08-09 21:32 ` [U-Boot] [PATCH v6 01/20] buildman: Fix a few typos Simon Glass
2014-08-09 21:32 ` [U-Boot] [PATCH v6 02/20] buildman: Add some notes about moving from MAKEALL Simon Glass
2014-08-09 21:32 ` [U-Boot] [PATCH v6 03/20] buildman: Allow building of current source tree Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 04/20] buildman: Move BuilderThread code to its own file Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 05/20] buildman: Sort command line options Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 06/20] buildman: Refactor output options Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 07/20] buildman: Add verbose option to display errors as they happen Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 08/20] buildman: Remove unused non-incremental build method code Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 09/20] buildman: Add an option to specify the buildman config file Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 10/20] buildman: Add a message indicating there are no errors Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 11/20] buildman: Add a few more toolchain examples to the README Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 12/20] buildman: Introduce an 'and' operator for board selection Simon Glass
2014-08-11 17:51 ` York Sun
2014-08-09 21:33 ` [U-Boot] [PATCH v6 13/20] buildman: Allow selection of the number of commits to build Simon Glass
2014-08-11 17:51 ` York Sun
2014-08-09 21:33 ` [U-Boot] [PATCH v6 14/20] patman: Move the 'git log' command into a function Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 15/20] patman: Only use git's --no-decorate when available Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 16/20] patman: buildman: Correct spelling of 'colour' Simon Glass
2014-08-09 22:01 ` Fabio Estevam
2014-08-09 22:17 ` Simon Glass
2014-08-09 22:29 ` Fabio Estevam
2014-08-09 22:34 ` Simon Glass
2014-08-10 5:23 ` York Sun
2014-08-11 20:34 ` Tom Rini [this message]
2014-08-09 21:33 ` [U-Boot] [PATCH v6 17/20] patman: Fix indentation in terminal.py Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 18/20] patman: Correct unit tests to run correctly Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 19/20] patman: Remove the -a option Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 20/20] RFC: Deprecate MAKEALL Simon Glass
2014-08-11 18:23 ` York Sun
2014-08-12 15:00 ` Simon Glass
2014-08-12 21:05 ` Tom Rini
2014-08-12 22:22 ` Simon Glass
2014-08-12 22:27 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811203436.GU19374@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox