public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] net: fec_mxc: Poll FEC_TBD_READY after polling TDAR
Date: Thu, 21 Aug 2014 19:18:10 +0200	[thread overview]
Message-ID: <201408211918.10764.marex@denx.de> (raw)
In-Reply-To: <1408641032-5432-1-git-send-email-fabio.estevam@freescale.com>

On Thursday, August 21, 2014 at 07:10:32 PM, Fabio Estevam wrote:
> When testing the FEC driver on a mx6solox we noticed that the TDAR bit gets
> always cleared prior then the READY bit is set in the last BD, which causes
> FEC transmission to fail.
> 
> As explained by Ye Li:
> 
> "The TDAR bit is set when the descriptors are all out from TX ring, but the
> descriptor properly is in transmitting not READY.

Again, I do not understand this sentence :-(

> These are two signals,
> and in Ic simulation, we found the TDAR always clear prior than the READY
> bit of last BD.

And this is the behavior of which version of the FEC IP, the "old" one or the 
one present in MX6slx ?

> In mx6solox, we use a latest version of FEC IP. It looks
> the intrinsic behave of TDAR bit is changed in this FEC version, not any
> bug in mx6sx."
>
> Fix this by polling the READY bit of BD after the TDAR polling, which
> covers the mx6solox case and does not harm for the other SoCs.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

[...]

Best regards,
Marek Vasut

  reply	other threads:[~2014-08-21 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21 17:10 [U-Boot] [PATCH v4] net: fec_mxc: Poll FEC_TBD_READY after polling TDAR Fabio Estevam
2014-08-21 17:18 ` Marek Vasut [this message]
2014-08-22  3:02   ` Li Ye-B37916
2014-08-22 10:26     ` Marek Vasut
2014-08-22 21:03       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201408211918.10764.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox