[U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

Simon Glass
2014-08-19T13:07:43Z

Hi Thierry,

On 19 August 2014 06:29, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Aug 18, 2014 at 12:37:46PM -0600, Simon Glass wrote:
>> Hi Thierry,
>>
>> On 18 August 2014 01:16, Thierry Reding <thierry.reding@gmail.com> wrote:
>> > From: Thierry Reding <treding@nvidia.com>
>> >
>> > The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes
>> > the second root port to a miniPCIe slot. Enable the PCIe controller and
>> > the network driver to allow the device to boot over the network.
>> >
>> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>>
>> Cool, I'll have to give this a try! Shouldn't the as3722 code be in
>> its own driver?
>
> I suppose it could. My intention was to move it out at some point when
> we needed it for another device. But if you prefer I can move it out in
> this series already.

Yes I think we should avoid putting driver code in board files.

BTW there is:

i2c_bus = i2c_get_bus_num_fdt(parent);

where parent is the fdt node of the parent. So you don't have to
hard-code the bus number. See tpm_decode_config() for an example.

Regards,
Simon