From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
Date: Mon, 25 Aug 2014 09:26:18 +0200 [thread overview]
Message-ID: <20140825092618.3bc93d38@amdc2363> (raw)
In-Reply-To: <53F6FAE7.40406@samsung.com>
Hi Tom,
> On 08/22/2014 09:12 AM, Lukasz Majewski wrote:
> > The commit (SHA1: 8fc171318e352) reintroduced correct values for
> > vendor and product IDs required for UMS gadget to work properly
> > either at Windows or Linux.
> >
> > This data was missing for GONI target, so this commit corrects this
> > mistake.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > ---
> > include/configs/s5p_goni.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
> > index 6e795bf..a51215d 100644
> > --- a/include/configs/s5p_goni.h
> > +++ b/include/configs/s5p_goni.h
> > @@ -91,6 +91,8 @@
> > #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
> > #define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
> > #define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
> > +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525
> > +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5
> > #define CONFIG_G_DNL_MANUFACTURER "Samsung"
> >
> > /* Actual modem binary size is 16MiB. Add 2MiB for bad block
> > handling */
> >
>
> Acked-by: Robert Baldyga <r.baldyga@samsung.com>
Tom, since Robert - the maintainer of the GONI board has acked the
patch and the patch itself adds only missing defines, could you pull
this patch to mainline ASAP?
It fixes build breaks caused by the GONI board :-)
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2014-08-25 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 7:12 [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget Lukasz Majewski
2014-08-22 8:10 ` Robert Baldyga
2014-08-25 7:26 ` Lukasz Majewski [this message]
2014-08-28 11:33 ` Minkyu Kang
2014-08-28 19:49 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825092618.3bc93d38@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox