From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/3] mx6sxsabresd: Add PCI support
Date: Mon, 25 Aug 2014 22:28:36 +0200 [thread overview]
Message-ID: <201408252228.36958.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKq=stZzLRjvukctQ+x3im3K9jZr6oWwMqnQUSghZfy2iQ@mail.gmail.com>
On Monday, August 25, 2014 at 10:24:19 PM, Otavio Salvador wrote:
> On Mon, Aug 25, 2014 at 5:11 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Mon, Aug 25, 2014 at 4:50 PM, Marek Vasut <marex@denx.de> wrote:
> >> On Monday, August 25, 2014 at 07:26:46 PM, Fabio Estevam wrote:
> >>> Tested with an Intel Wireless PCI 7260HMW card:
> >>>
> >>> U-Boot 2014.10-rc1-16576-g4a8a8a8-dirty (Aug 23 2014 - 16:05:11)
> >>>
> >>> CPU: Freescale i.MX6SX rev1.0 at 792 MHz
> >>> Reset cause: WDOG
> >>> Board: MX6SX SABRE SDB
> >>> I2C: ready
> >>> DRAM: 1 GiB
> >>> MMC: FSL_SDHC: 0
> >>>
> >>> 00:01.0 - 16c3:abcd - Bridge device
> >>>
> >>> 01:00.0 - 8086:08b1 - Network controller
> >>>
> >>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Should this output be really part of the commit message?
> >
> > Personally I don't see any problem with it, but if Stefano prefers I
> > can remove it and send a v4.
>
> I like to have it included.
Please explain what exactly is the worth of having 50% of commit message contain
standard U-Boot boot output, which is completely unrelated to what the commit
implements. The rest of the commit message fails to explain what the commit
does.
I would like to hear your reasoning for your claim.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-08-25 20:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 17:26 [U-Boot] [PATCH v3 1/3] mx6: imx-regs: Provide a structure for GPC registers Fabio Estevam
2014-08-25 17:26 ` [U-Boot] [PATCH v3 2/3] pcie_imx: Add mx6solox support Fabio Estevam
2014-08-25 19:50 ` Marek Vasut
2014-09-09 15:26 ` Stefano Babic
2014-08-25 17:26 ` [U-Boot] [PATCH v3 3/3] mx6sxsabresd: Add PCI support Fabio Estevam
2014-08-25 19:50 ` Marek Vasut
2014-08-25 20:11 ` Fabio Estevam
2014-08-25 20:24 ` Otavio Salvador
2014-08-25 20:28 ` Marek Vasut [this message]
2014-08-25 20:31 ` Otavio Salvador
2014-08-25 20:47 ` Marek Vasut
2014-08-29 20:19 ` Fabio Estevam
2014-08-29 22:29 ` Marek Vasut
2014-08-29 22:54 ` Fabio Estevam
2014-08-30 12:31 ` Marek Vasut
2014-09-09 15:26 ` Stefano Babic
2014-09-09 15:26 ` [U-Boot] [PATCH v3 1/3] mx6: imx-regs: Provide a structure for GPC registers Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201408252228.36958.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox