From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: cpsw: am335x: Drop constant link checking from rx/tx path's
Date: Tue, 26 Aug 2014 11:14:05 -0400 [thread overview]
Message-ID: <20140826151405.GQ19374@bill-the-cat> (raw)
In-Reply-To: <1408958779-1709-1-git-send-email-sr@denx.de>
On Mon, Aug 25, 2014 at 11:26:19AM +0200, Stefan Roese wrote:
> We noticed on the DXR2 platform (AM335x with a SMSC LAN9303 switch connected
> to the CPSW MAC) that the network performance in U-Boot is quite poor. Only
> when the transfer is started without a cable connected, and the cable is
> plugged after the first timeout "T" occured, an increased in performance
> can be seen. Debugging has revealed, that the cpsw driver has constant
> link checking builtin into the rx and tx functions. This results in the
> bad performance and seems to be unnecessary. The link has already been
> checked in the init function, before the transfer is started. This usually
> is sufficient.
>
> BTW: I have seen no other network driver in U-Boot so far, that constantly
> checks for link in the rx / tx functions.
Yes, this strongly feels like a bring-up sanity check thing that was
left in by accident.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140826/c0e03441/attachment.pgp>
next prev parent reply other threads:[~2014-08-26 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 9:26 [U-Boot] [PATCH] net: cpsw: am335x: Drop constant link checking from rx/tx path's Stefan Roese
2014-08-26 15:14 ` Tom Rini [this message]
2014-08-29 14:41 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826151405.GQ19374@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox